Skip to content

Honor a cache-restored build when a versioned extension mismatches #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivammathur merged 2 commits into from
Aug 19, 2026
Merged

Honor a cache-restored build when a versioned extension mismatches #1108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d571bd3
fix: honor a cache-restored build when a versioned extension mismatches
ibrahimlawal-paystack Aug 19, 2026
1ebf4d6
fix: preserve versioned builds in ext_dir instead of a separate cache…
ibrahimlawal-paystack Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/scripts/extensions/add_extensions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,12 +214,36 @@ add_pecl_extension() {
pecl_version=$(get_pecl_version "$extension" "$pecl_version")
fi
ext_version=$(php -r "echo phpversion('$extension');")
# The PHP package install itself can bundle its own default build of a
# versioned extension (e.g. redis ships with its own recent version),
# which overwrites ext_dir/$extension.so before this function ever runs.
# shared_extension only checks that *a* file exists, not which version, so
# a build matching the pinned version - even one cache-extensions already
# restored into ext_dir - never gets a chance: this always fell straight
# through to pecl_install regardless of caching. Preserve built versions
# in ext_dir itself under a name with no .so suffix, so cache-extensions
# (which caches all of ext_dir) picks them up automatically, and the PHP
# package install's own file can't collide with or overwrite them. On a
# mismatch, restore the matching preserved build before falling back to a
# full pecl_install.
if [ -n "$pecl_version" ] && check_extension "$extension" && [ "${ext_version/-/}" != "$pecl_version" ]; then
preserved="${ext_dir:?}/$extension-$pecl_version"
if [ -e "$preserved" ]; then
disable_extension_helper "$extension" >/dev/null 2>&1
sudo cp "$preserved" "${ext_dir:?}/$extension.so"
enable_extension "$extension" "$prefix"
ext_version=$(php -r "echo phpversion('$extension');")
fi
fi
if check_extension "$extension" && [[ -z "$pecl_version" || (-n "$pecl_version" && "${ext_version/-/}" == "$pecl_version") ]]; then
add_log "${tick:?}" "$extension" "Enabled"
else
[ -n "$pecl_version" ] && pecl_version="-$pecl_version"
pecl_install "$extension$pecl_version" || ( [ "${fail_fast:?}" = "false" ] && add_extension "$extension" "$(get_extension_prefix "$extension")" >/dev/null 2>&1)
extension_version="$(php -r "echo phpversion('$extension');")"
if check_extension "$extension" && [ -n "$extension_version" ]; then
sudo cp "${ext_dir:?}/$extension.so" "${ext_dir:?}/$extension-$extension_version" 2>/dev/null || true
fi
[ -n "$extension_version" ] && extension_version="-$extension_version"
add_extension_log "$extension$extension_version" "Installed and enabled"
fi
Expand Down