Skip to content

Add debug mode #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stephenfin wants to merge 1 commit into from
Closed

Add debug mode #61

stephenfin wants to merge 1 commit into from

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented May 30, 2023

It can be helpful to debug the behavior of the bot tools without having anything post to Slack. Make this possible, starting with the doctext tool.

Signed-off-by: Stephen Finucane stephenfin@redhat.com

@stephenfin
Add debug mode
86cd9eb 
It can be helpful to debug the behavior of the bot tools without having
anything post to Slack. Make this possible, starting with the doctext
tool.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@openshift-ci openshift-ci bot requested review from MaysaMacedo and mdbooth May 30, 2023 11:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierreprinetti
Copy link
Contributor

pierreprinetti commented Jun 6, 2023 •
edited
Loading

One thing you could do is to have the main code use a Notifier interface, that is either the Slack client or a printf to stdout.

This could be configured by a command line switch: --notify={slack,stdout} defaulting to slack for example (or an environment variable, as you see fit).

I would leave the TEAM_DICT parsing logic unchanged to have the two flows match one another as closely as possible.

@stephenfin
Copy link
Contributor Author

stephenfin commented Jun 6, 2023

One thing you could do is to have the main code use a Notifier interface, that is either the Slack client or a printf to stdout.

This could be configured by a command line switch: --notify={slack,stdout} defaulting to slack for example (or an environment variable, as you see fit).

I considered exactly this and decided YAGNI. I think the same can be said of this entire PR though. I think I'll can this for now and will resurrect it if I need to debug stuff again.

I would leave the TEAM_DICT parsing logic unchanged to have the two flows match one another as closely as possible.

A fair point.

@stephenfin stephenfin closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

No one assigned

Labels

approved

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenfin @pierreprinetti