Move notebook fixture to deletetest file to minimize the dependency on changes in PR jupyter#3475. This should be update once that PR is merged

sheshtawy · sheshtawy · commit 5dbb2ac97552 · 2018-04-02T16:49:02.000-04:00
diff --git a/notebook/tests/selenium/test_deletecell.py b/notebook/tests/selenium/test_deletecell.py
@@ -2,6 +2,10 @@
 import pytest
 from .utils import Notebook
 
+@pytest.fixture
+def notebook(authenticated_browser):
+    return Notebook.new_notebook(authenticated_browser)
+
 def get_cells_contents(nb):
     JS = 'return Jupyter.notebook.get_cells().map(function(c) {return c.get_text();})'
     return nb.browser.execute_script(JS)
diff --git a/notebook/tests/selenium/utils.py b/notebook/tests/selenium/utils.py
@@ -154,7 +154,8 @@ def add_cell(self, index=-1, cell_type="code", content=""):
         new_index = index + 1 if index >= 0 else index
         if content:
             self.edit_cell(index=index, content=content)
-        self.convert_cell_type(index=new_index, cell_type=cell_type)
+        if cell_type != 'code':
+            self.convert_cell_type(index=new_index, cell_type=cell_type)
 
     def add_markdown_cell(self, index=-1, content="", render=True):
         self.add_cell(index, cell_type="markdown")
