Update references.md#117
Merged
ko1nksm merged 3 commits intoshellspec:masterfrom Nov 10, 2020
ldicarlo:patch-1
Merged
Conversation
typo ? Actually I am not sure that I understand this sentence; Could it be: > Even shell scripts are processed as external commands (and thus respecting shebang), so they are not covered by coverage. (if my understanding's right)
ldicarlo
commented
Nov 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 66.18% 66.18%
=======================================
Files 98 98
Lines 4267 4267
=======================================
Hits 2824 2824
Misses 1443 1443 Continue to review full report at Codecov.
|
ldicarlo
commented
Nov 9, 2020
docs/references.md
Outdated
| This is primarily designed for external command calls. | ||
| The external command does not have to be a shell script. | ||
| Even shell scripts are processed as external commands (respect shebang), so it not covered by coverage. | ||
| Even shell scripts are processed as external commands (respect shebang), so it is not covered by coverage. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| Even shell scripts are processed as external commands (respect shebang), so it is not covered by coverage. | |
| Even shell scripts are executed as external commands according to the shebang, so they are not covered by coverage. |
Contributor
Author
There was a problem hiding this comment.
(I added it if you want, or just close this PR, as you wish ;))
following @ko1nksm suggestion
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typo ?
Actually I am not sure that I understand this sentence;
Could it be:
(if my understanding's right)