Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grep()treats the final empty element from splitting newline-terminated input as an actual line. As a result,ShellString('text\n').grep(/^$/)returns a blank match with exit code 0, and inverted matching can produce an extra line even when every input line matches.Skip that final empty element when matching lines. Preserve actual blank lines, line numbering and context, and use the existing no-match error handling when no physical line matches. This leaves the separate after-context bounds change in #1268 untouched.
Regression coverage includes piped input, empty files, real blank lines, inverted matches and numbered context. The existing inverted-match count is corrected to exclude its phantom final line.
Validation on Windows with Node.js 24.22.1:
git diff --check: passed.Investigated, implemented and tested with OpenAI Codex assistance. No human review is claimed.