Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 12, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
touch('-a', path)andtouch('-m', path)throwShellJSInternalErrorwhenpathdoes not exist, after already creating the empty file. The pre-creation stat is still null when the code reads the timestamp it should preserve. This also affects selective timestamp updates with a date/reference file and dangling symlink targets.Read the new file's stat after creation when no original stat was available. Existing files retain their original stat, and
-cstill returns without creating a file.Validation on Linux / Node.js 24.19.0:
npm testand coverage runs: 653 passed, 6 existing skips each;touch.jshas 100% statement/branch/function/line coverage.check-node-support, generated-documentation consistency andgit diff --checkpass.touchpass across existing/new files, direct paths/symlinks, and current/date/reference timestamps.The six existing explicit skips are in
cmd.js: five async cases and the missing-exec-path case. Native Windows/macOS and other Node versions were not run locally; the two new symlink cases use the project's existing Windows skip helper.Prepared and tested with AI assistance (OpenAI Codex). No human review is claimed.