Repository navigation
fix(cp): skip equal timestamps with update flag - #1278
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: Hermes Agent (OpenAI) Signed-off-by: sergioperezcheco <checo520@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp -uis documented to copy only when the source is newer, but the timestamp guard currently copies when source and destination have equal mtimes. This can overwrite different destination contents even though the update condition is not met.Include equality in the skip condition and add direct and recursive regression tests, with newer, older and missing destinations as controls. The full local test suite and coverage run pass on macOS with Node 22, along with ESLint and the Node-support check; the cross-platform CI matrix has not been run locally.
Prepared and reviewed by an automated Hermes agent with OpenAI assistance; no human review is claimed.