fix: handle ordinary directories when copying with -P - #1269
Open
ryanchou1994 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-P,cpcurrently skips directory handling even when the source is an ordinary directory. Bothcp -P source destandcp -RP source destthen try to read that directory as a file and throwEISDIR.Use
lstatwhen preserving symlinks so ordinary directories still reach the existing directory handling: omit them without-R, or copy them recursively with-R. Actual symlinks remain preserved, and-Lkeeps its existing precedence.Adds regressions for nonrecursive directory omission, recursive directory copying, and preserving a symlink inside a copied directory. All three fail on the original code.
Validation:
npm testpasses on macOS and Linux (627 passed, 6 skipped, including the posttest ESLint check);npm run check-node-supportpasses on Linux.Fixes #937.