test(find): add test case for absolute path read#1228
Open
cristiand391 wants to merge 2 commits intoshelljs:mainfrom
Open
test(find): add test case for absolute path read#1228cristiand391 wants to merge 2 commits intoshelljs:mainfrom
cristiand391 wants to merge 2 commits intoshelljs:mainfrom
Conversation
nfischer
reviewed
Jul 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
==========================================
- Coverage 97.47% 96.72% -0.75%
==========================================
Files 35 35
Lines 1467 1467
==========================================
- Hits 1430 1419 -11
- Misses 37 48 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test case for
shelljs.findtaking an absolute path.The current tests are passing on windows but only cover relative cases, I suspect the bug on windows may be with the drive -letter at the start of an absolute path.
#1227