a few unreachable->unimplemented, clippy (RustPython#6405)

youknowone · web-flow · commit bfd873a8b872 · 2025-12-12T01:13:28.000+09:00
* unreachable -&gt; unimplemented

* Fix clippy on 1.92
diff --git a/crates/codegen/src/unparse.rs b/crates/codegen/src/unparse.rs
@@ -380,7 +380,11 @@ impl<'a, 'b, 'c> Unparser<'a, 'b, 'c> {
                     .fmt(self.f)?
             }
             Expr::NumberLiteral(ruff::ExprNumberLiteral { value, .. }) => {
-                const { assert!(f64::MAX_10_EXP == 308) };
+                #[allow(clippy::correctness, clippy::assertions_on_constants)]
+                const {
+                    assert!(f64::MAX_10_EXP == 308)
+                };
+
                 let inf_str = "1e309";
                 match value {
                     ruff::Number::Int(int) => int.fmt(self.f)?,
diff --git a/crates/stdlib/src/contextvars.rs b/crates/stdlib/src/contextvars.rs
@@ -508,7 +508,7 @@ mod _contextvars {
         }
 
         fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-            unreachable!("use slot_new")
+            unimplemented!("use slot_new")
         }
     }
 
@@ -585,7 +585,7 @@ mod _contextvars {
             Err(vm.new_runtime_error("Tokens can only be created by ContextVars"))
         }
         fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-            unreachable!("use slot_new")
+            unimplemented!("use slot_new")
         }
     }
 
diff --git a/crates/stdlib/src/ssl.rs b/crates/stdlib/src/ssl.rs
@@ -4116,7 +4116,7 @@ mod _ssl {
         }
 
         fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-            unreachable!("use slot_new")
+            unimplemented!("use slot_new")
         }
     }
 
diff --git a/crates/vm/src/builtins/bool.rs b/crates/vm/src/builtins/bool.rs
@@ -6,7 +6,6 @@ use crate::{
     class::PyClassImpl,
     convert::{IntoPyException, ToPyObject, ToPyResult},
     function::{FuncArgs, OptionalArg},
-    identifier,
     protocol::PyNumberMethods,
     types::{AsNumber, Constructor, Representable},
 };
@@ -115,7 +114,7 @@ impl Constructor for PyBool {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/builtins/classmethod.rs b/crates/vm/src/builtins/classmethod.rs
@@ -103,7 +103,7 @@ impl Constructor for PyClassMethod {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/builtins/complex.rs b/crates/vm/src/builtins/complex.rs
@@ -10,7 +10,6 @@ use crate::{
         PyArithmeticValue::{self, *},
         PyComparisonValue,
     },
-    identifier,
     protocol::PyNumberMethods,
     stdlib::warnings,
     types::{AsNumber, Comparable, Constructor, Hashable, PyComparisonOp, Representable},
diff --git a/crates/vm/src/builtins/int.rs b/crates/vm/src/builtins/int.rs
@@ -244,7 +244,7 @@ impl Constructor for PyInt {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/builtins/object.rs b/crates/vm/src/builtins/object.rs
@@ -111,7 +111,7 @@ impl Constructor for PyBaseObject {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/builtins/staticmethod.rs b/crates/vm/src/builtins/staticmethod.rs
@@ -61,7 +61,7 @@ impl Constructor for PyStaticMethod {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/builtins/type.rs b/crates/vm/src/builtins/type.rs
@@ -22,7 +22,6 @@ use crate::{
     },
     convert::ToPyResult,
     function::{FuncArgs, KwArgs, OptionalArg, PyMethodDef, PySetterValue},
-    identifier,
     object::{Traverse, TraverseFn},
     protocol::{PyIterReturn, PyMappingMethods, PyNumberMethods, PySequenceMethods},
     types::{
@@ -1289,7 +1288,7 @@ impl Constructor for PyType {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/builtins/weakref.rs b/crates/vm/src/builtins/weakref.rs
@@ -45,7 +45,7 @@ impl Constructor for PyWeak {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/class.rs b/crates/vm/src/class.rs
@@ -3,7 +3,6 @@
 use crate::{
     builtins::{PyBaseObject, PyType, PyTypeRef},
     function::PyMethodDef,
-    identifier,
     object::Py,
     types::{PyTypeFlags, PyTypeSlots, hash_not_implemented},
     vm::Context,
diff --git a/crates/vm/src/exceptions.rs b/crates/vm/src/exceptions.rs
@@ -717,7 +717,7 @@ impl Constructor for PyBaseException {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: FuncArgs, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/function/protocol.rs b/crates/vm/src/function/protocol.rs
@@ -3,7 +3,6 @@ use crate::{
     AsObject, PyObject, PyObjectRef, PyPayload, PyResult, TryFromObject, VirtualMachine,
     builtins::{PyDict, PyDictRef, iter::PySequenceIterator},
     convert::ToPyObject,
-    identifier,
     object::{Traverse, TraverseFn},
     protocol::{PyIter, PyIterIter, PyMapping, PyMappingMethods},
     types::{AsMapping, GenericMethod},
diff --git a/crates/vm/src/stdlib/ast/python.rs b/crates/vm/src/stdlib/ast/python.rs
@@ -77,7 +77,7 @@ pub(crate) mod _ast {
         }
 
         fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-            unreachable!("use slot_new")
+            unimplemented!("use slot_new")
         }
     }
 
diff --git a/crates/vm/src/stdlib/ctypes/array.rs b/crates/vm/src/stdlib/ctypes/array.rs
@@ -76,7 +76,7 @@ impl Constructor for PyCArrayType {
     type Args = PyObjectRef;
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
@@ -305,7 +305,7 @@ impl Constructor for PyCArray {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/stdlib/ctypes/base.rs b/crates/vm/src/stdlib/ctypes/base.rs
@@ -662,7 +662,7 @@ impl Constructor for PyCSimple {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/stdlib/ctypes/function.rs b/crates/vm/src/stdlib/ctypes/function.rs
@@ -330,7 +330,7 @@ impl Constructor for PyCFuncPtr {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/stdlib/ctypes/pointer.rs b/crates/vm/src/stdlib/ctypes/pointer.rs
@@ -90,7 +90,7 @@ impl Constructor for PyCPointer {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/stdlib/ctypes/structure.rs b/crates/vm/src/stdlib/ctypes/structure.rs
@@ -44,7 +44,7 @@ impl Constructor for PyCStructType {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
@@ -332,7 +332,7 @@ impl Constructor for PyCStructure {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/stdlib/ctypes/union.rs b/crates/vm/src/stdlib/ctypes/union.rs
@@ -48,7 +48,7 @@ impl Constructor for PyCUnionType {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
@@ -191,7 +191,7 @@ impl Constructor for PyCUnion {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/stdlib/itertools.rs b/crates/vm/src/stdlib/itertools.rs
@@ -16,7 +16,6 @@ mod decl {
         },
         convert::ToPyObject,
         function::{ArgCallable, ArgIntoBool, FuncArgs, OptionalArg, OptionalOption, PosArgs},
-        identifier,
         protocol::{PyIter, PyIterReturn, PyNumber},
         raise_if_stop,
         stdlib::{sys, warnings},
@@ -1256,7 +1255,7 @@ mod decl {
         }
 
         fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-            unreachable!("use slot_new")
+            unimplemented!("use slot_new")
         }
     }
 
diff --git a/crates/vm/src/stdlib/operator.rs b/crates/vm/src/stdlib/operator.rs
@@ -7,7 +7,6 @@ mod _operator {
         builtins::{PyInt, PyIntRef, PyStr, PyStrRef, PyTupleRef, PyType, PyTypeRef},
         common::wtf8::Wtf8,
         function::{ArgBytesLike, Either, FuncArgs, KwArgs, OptionalArg},
-        identifier,
         protocol::PyIter,
         recursion::ReprGuard,
         types::{Callable, Constructor, PyComparisonOp, Representable},
diff --git a/crates/vm/src/stdlib/os.rs b/crates/vm/src/stdlib/os.rs
@@ -1506,7 +1506,9 @@ pub(super) mod _os {
     #[cfg(target_os = "linux")]
     #[pyfunction]
     fn copy_file_range(args: CopyFileRangeArgs<'_>, vm: &VirtualMachine) -> PyResult<usize> {
+        #[allow(clippy::unnecessary_option_map_or_else)]
         let p_offset_src = args.offset_src.as_ref().map_or_else(std::ptr::null, |x| x);
+        #[allow(clippy::unnecessary_option_map_or_else)]
         let p_offset_dst = args.offset_dst.as_ref().map_or_else(std::ptr::null, |x| x);
         let count: usize = args
             .count
diff --git a/crates/vm/src/stdlib/typevar.rs b/crates/vm/src/stdlib/typevar.rs
@@ -610,7 +610,7 @@ impl Constructor for ParamSpec {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
@@ -772,7 +772,7 @@ impl Constructor for TypeVarTuple {
     }
 
     fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
-        unreachable!("use slot_new")
+        unimplemented!("use slot_new")
     }
 }
 
diff --git a/crates/vm/src/types/slot.rs b/crates/vm/src/types/slot.rs
@@ -7,7 +7,6 @@ use crate::{
     function::{
         Either, FromArgs, FuncArgs, OptionalArg, PyComparisonValue, PyMethodDef, PySetterValue,
     },
-    identifier,
     protocol::{
         PyBuffer, PyIterReturn, PyMapping, PyMappingMethods, PyNumber, PyNumberMethods,
         PyNumberSlots, PySequence, PySequenceMethods,
diff --git a/crates/vm/src/vm/vm_object.rs b/crates/vm/src/vm/vm_object.rs
@@ -2,7 +2,6 @@ use super::PyMethod;
 use crate::{
     builtins::{PyBaseExceptionRef, PyList, PyStrInterned, pystr::AsPyStr},
     function::IntoFuncArgs,
-    identifier,
     object::{AsObject, PyObject, PyObjectRef, PyResult},
     stdlib::sys,
     vm::VirtualMachine,

Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,7 @@ mod _contextvars {`
`508`	`508`	`}`
`509`	`509`
`510`	`510`	`fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {`
`511`		`- unreachable!("use slot_new")`
	`511`	`+ unimplemented!("use slot_new")`
`512`	`512`	`}`
`513`	`513`	`}`
`514`	`514`
`@@ -585,7 +585,7 @@ mod _contextvars {`
`585`	`585`	`Err(vm.new_runtime_error("Tokens can only be created by ContextVars"))`
`586`	`586`	`}`
`587`	`587`	`fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {`
`588`		`- unreachable!("use slot_new")`
	`588`	`+ unimplemented!("use slot_new")`
`589`	`589`	`}`
`590`	`590`	`}`
`591`	`591`
Original file line number	Diff line number	Diff line change
`@@ -4116,7 +4116,7 @@ mod _ssl {`
`4116`	`4116`	`}`
`4117`	`4117`
`4118`	`4118`	`fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {`
`4119`		`- unreachable!("use slot_new")`
	`4119`	`+ unimplemented!("use slot_new")`
`4120`	`4120`	`}`
`4121`	`4121`	`}`
`4122`	`4122`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ use crate::{`
`6`	`6`	`class::PyClassImpl,`
`7`	`7`	`convert::{IntoPyException, ToPyObject, ToPyResult},`
`8`	`8`	`function::{FuncArgs, OptionalArg},`
`9`		`- identifier,`
`10`	`9`	`protocol::PyNumberMethods,`
`11`	`10`	`types::{AsNumber, Constructor, Representable},`
`12`	`11`	`};`
`@@ -115,7 +114,7 @@ impl Constructor for PyBool {`
`115`	`114`	`}`
`116`	`115`
`117`	`116`	`fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {`
`118`		`- unreachable!("use slot_new")`
	`117`	`+ unimplemented!("use slot_new")`
`119`	`118`	`}`
`120`	`119`	`}`
`121`	`120`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ impl Constructor for PyClassMethod {`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {`
`106`		`- unreachable!("use slot_new")`
	`106`	`+ unimplemented!("use slot_new")`
`107`	`107`	`}`
`108`	`108`	`}`
`109`	`109`
Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ impl Constructor for PyInt {`
`244`	`244`	`}`
`245`	`245`
`246`	`246`	`fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {`
`247`		`- unreachable!("use slot_new")`
	`247`	`+ unimplemented!("use slot_new")`
`248`	`248`	`}`
`249`	`249`	`}`
`250`	`250`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ impl Constructor for PyBaseObject {`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {`
`114`		`- unreachable!("use slot_new")`
	`114`	`+ unimplemented!("use slot_new")`
`115`	`115`	`}`
`116`	`116`	`}`
`117`	`117`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ impl Constructor for PyStaticMethod {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {`
`64`		`- unreachable!("use slot_new")`
	`64`	`+ unimplemented!("use slot_new")`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@ use crate::{`
`22`	`22`	`},`
`23`	`23`	`convert::ToPyResult,`
`24`	`24`	`function::{FuncArgs, KwArgs, OptionalArg, PyMethodDef, PySetterValue},`
`25`		`- identifier,`
`26`	`25`	`object::{Traverse, TraverseFn},`
`27`	`26`	`protocol::{PyIterReturn, PyMappingMethods, PyNumberMethods, PySequenceMethods},`
`28`	`27`	`types::{`
`@@ -1289,7 +1288,7 @@ impl Constructor for PyType {`
`1289`	`1288`	`}`
`1290`	`1289`
`1291`	`1290`	`fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {`
`1292`		`- unreachable!("use slot_new")`
	`1291`	`+ unimplemented!("use slot_new")`
`1293`	`1292`	`}`
`1294`	`1293`	`}`
`1295`	`1294`