Add SetNameArgs

jopemachine · jopemachine · commit 2994e3f3444e · 2022-09-17T14:08:43.000+09:00
diff --git a/vm/src/builtins/property.rs b/vm/src/builtins/property.rs
@@ -1,9 +1,8 @@
 /*! Python `property` descriptor class.
 
 */
-use super::{PyType, PyTypeRef};
+use super::{PyStrRef, PyType, PyTypeRef};
 use crate::common::lock::PyRwLock;
-use crate::function::PosArgs;
 use crate::{
     class::PyClassImpl,
     function::{FuncArgs, PySetterValue},
@@ -88,6 +87,14 @@ impl GetDescriptor for PyProperty {
     }
 }
 
+#[derive(FromArgs)]
+struct SetNameArgs {
+    #[pyarg(positional)]
+    owner: PyObjectRef,
+    #[pyarg(positional)]
+    str: PyStrRef,
+}
+
 #[pyclass(with(Constructor, Initializer, GetDescriptor), flags(BASETYPE))]
 impl PyProperty {
     // Descriptor methods
@@ -156,20 +163,8 @@ impl PyProperty {
     }
 
     #[pymethod(magic)]
-    fn set_name(&self, args: PosArgs, vm: &VirtualMachine) -> PyResult<()> {
-        let arg_len = args.into_vec().len();
-
-        if arg_len != 2 {
-            Err(vm.new_exception_msg(
-                vm.ctx.exceptions.type_error.to_owned(),
-                format!(
-                    "__set_name__() takes 2 positional arguments but {} were given",
-                    arg_len
-                ),
-            ))
-        } else {
-            Ok(())
-        }
+    fn set_name(&self, _args: SetNameArgs, _vm: &VirtualMachine) -> PyResult<()> {
+        Ok(())
     }
 
     // Python builder functions
