Skip to content

Fix bug when doing get_data from an Array with one element. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avilchess merged 3 commits into from
May 6, 2019
Merged

Fix bug when doing get_data from an Array with one element. #50

avilchess merged 3 commits into from
May 6, 2019

Conversation

@avilchess
Copy link
Contributor

@avilchess avilchess commented May 6, 2019 •
edited
Loading

This PR solves one issue when doing get_data().tolist() on a Khiva.Array with one element.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

License

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

@avilchess avilchess requested a review from otorreno May 6, 2019 15:36
@codecov
Copy link

codecov bot commented May 6, 2019 •
edited
Loading

Codecov Report

Merging #50 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   94.59%   94.61%   +0.01%     
==========================================
  Files          14       14              
  Lines         870      872       +2     
==========================================
+ Hits          823      825       +2     
  Misses         47       47
Flag Coverage Δ
#Linux 93.34% <100%> (+0.01%) ⬆️
#MacOS 93.11% <100%> (+0.01%) ⬆️
#Windows 94.26% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
khiva/array.py 88.28% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1027f66...ea21c72. Read the comment docs.

otorreno
otorreno approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@otorreno otorreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avilchess avilchess merged commit 1c719c6 into master May 6, 2019
@avilchess avilchess deleted the fix/getData branch May 6, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@otorreno otorreno otorreno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avilchess @otorreno