Skip to content

Fix/clustering #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avilchess merged 8 commits into from
Feb 27, 2019
Merged

Fix/clustering #44

avilchess merged 8 commits into from
Feb 27, 2019

Conversation

@avilchess
Copy link
Contributor

@avilchess avilchess commented Feb 27, 2019

Make sure you have checked all steps below.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

License

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

dcuestam
dcuestam approved these changes Feb 27, 2019
View reviewed changes
CHANGES.rst Outdated
- Added Ljung-Box test.
- Added Installation script for Windows.
- Added SBD distance function.
- Added Header checks in all header files from core library and bindings.
Copy link
Contributor

@dcuestam dcuestam Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes of the headers of stomp??

@codecov
Copy link

codecov bot commented Feb 27, 2019 •
edited
Loading

Codecov Report

Merging #44 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   94.21%   94.56%   +0.34%     
==========================================
  Files          14       14              
  Lines         865      865              
==========================================
+ Hits          815      818       +3     
+ Misses         50       47       -3
Flag Coverage Δ
#Linux 93.29% <ø> (?)
#MacOS 93.06% <ø> (?)
#Windows 94.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
khiva/library.py 91.8% <0%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be86f4...c6175bf. Read the comment docs.

@avilchess avilchess merged commit d8be671 into master Feb 27, 2019
@avilchess avilchess deleted the fix/clustering branch February 27, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dcuestam dcuestam dcuestam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avilchess @dcuestam