tiny fix: fix glm46v launch and transformers issue #15476
Conversation
Summary of ChangesHello @yhyang201, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compatibility issue that prevented the successful launch of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adjusts the version check for the transformers library, changing the required version from 5.0.0 to 4.57.3 and refactoring the logic for better clarity. While the changes correctly enforce the new version requirement for glm-4.6v models, a related warning message for other models was not updated. This results in a potentially confusing warning for users with certain transformers versions. I've added a comment to address this.
| f"Please upgrade transformers to > {required_version}" | ||
| ) | ||
| elif not needs_tf_v5: | ||
| elif tf_version > required_version: |
There was a problem hiding this comment.
The condition for this warning has been changed to check for tf_version > "4.57.3". However, the warning message on line 867 still refers to Transformers >=5.0.0. This can be misleading for users with a transformers version between 4.57.3 and 5.0.0, as they will see a warning that seems inapplicable to their version. To avoid confusion, please update the warning message to be consistent with the new required_version.
1 participant
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist