Fix 'Scheduler' object has no attribute 'port_args' error #15470
Conversation
lambert0312
requested review from
Ying1123,
hnyls2002,
merrymercy and
xiezhq-hermann
as code owners
Summary of ChangesHello @lambert0312, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical runtime error where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an AttributeError that occurs when initializing the scheduler with MTP enabled. By adding self.port_args = port_args in the Scheduler's __init__ method, the init_model_worker function can now access self.port_args.nccl_port without crashing. The fix is direct and effective.
| self.pp_size = server_args.pp_size | ||
| self.dp_size = server_args.dp_size | ||
| self.nccl_port = port_args.nccl_port | ||
| self.port_args = port_args |
There was a problem hiding this comment.
While this change correctly fixes the AttributeError, it introduces a small redundancy. The self.port_args attribute appears to be used only to access nccl_port, but self.nccl_port is already initialized from port_args.nccl_port on the preceding line.
For better code clarity and to avoid storing the entire port_args object, a potential follow-up refactoring could be to consistently use self.nccl_port throughout the class. For instance, in init_model_worker, the calls to MTPWorkerV2 and MTPWorker could be changed to use nccl_port=self.nccl_port. This would align with how TpModelWorker and draft_worker_kwargs are handled in the same method and would allow removing self.port_args.
1 participant
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist