Skip to content

Update default role policy - #45

Merged
eahefnawy merged 1 commit into
serverless-components:masterfrom
alisalahio:update-default-role-policy
Apr 20, 2021
Merged

Update default role policy#45
eahefnawy merged 1 commit into
serverless-components:masterfrom
alisalahio:update-default-role-policy

Conversation

@alisalahio

Copy link
Copy Markdown
Contributor

Comment thread serverless.component.yml
@@ -1,5 +1,5 @@
name: aws-lambda
version: 2.0.2
version: 3.0.0

@MattiaPette MattiaPette Apr 12, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should not be a major release, maybe a patch is a better fit?

Suggested change
version: 3.0.0
version: 2.0.3

@alisalahio

alisalahio commented Apr 12, 2021

Copy link
Copy Markdown
Contributor Author

@MattiaPette I'm not sure, but this is how the express component did it, possibly because it's a breaking change.

Are you sure I should change it?

@joshvtech

joshvtech commented Apr 12, 2021

Copy link
Copy Markdown

Any idea how long this PR could take? Can this be fixed locally whilst we wait?

@janpio

janpio commented Apr 17, 2021

Copy link
Copy Markdown

This currently leads to the normal "Deploy Lambda" getting started project on https://app.serverless.com/ being broken :/

Update: As a hack I published component: aws-lambda-fixed based on this PR and this seems to allow me to deploy to Lambda.

@mthan160

mthan160 commented Apr 19, 2021

Copy link
Copy Markdown

This currently leads to the normal "Deploy Lambda" getting started project on https://app.serverless.com/ being broken :/

Update: As a hack I published component: aws-lambda-fixed based on this PR and this seems to allow me to deploy to Lambda.

Yes I can confirm that, it's broken because of this.

I tried tearing apart the npm package serverless and couldn't find any references to AWSLambdaFullAccess - where can we make the changes suggested in this PR?

@janpio

janpio commented Apr 19, 2021

Copy link
Copy Markdown

If you are using that example, is says component: aws-lamda in the serverless.yml. Components seem to be downloaded on runtime, and not part of your node_modules if I got that right - which is why I published the aws-lambda-fixed package to that serverless components registry. (But I am also super green in all of this, so 🤷 if this is the right way to do this)

@LukeFerris

Copy link
Copy Markdown

@janpio - thanks! I'm a Serverless beginner and there's nothing quite like following the default flow and it throwing an error you don't understand. I changed the serverless.yml to your update and it deployed successfully. I am in your debt.

If I've understood correctly, this is a breaking bug for all new lambda components? (including new, easily confused people like me). Is there some way we can increase the priority for the merge?

@eahefnawy eahefnawy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @alisalahio! 🙌

@eahefnawy
eahefnawy merged commit 5cb9b61 into serverless-components:master Apr 20, 2021
@eahefnawy

Copy link
Copy Markdown
Member

This is now published! Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants