Adhere to Serverless.yml exclude list#13097
Open
QAnders wants to merge 3 commits intoserverless:mainfrom
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
QAnders
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #12379
Issue is that Docker runs as
rootand adds persistence directories as ownerrootandglobbythrows as it has no access. The code is set to fail silently why it just skips excludes and includes alldevDependenciesas well in final package.My suggested code will take the
package.patternslist and exclude any excluded patterns from theglobbyreading.Hence, if I exclude the Docker persistence directories in
package.patternsthey will not be read byglobbyand I will get a properzipwith excludeddevDependencies.Closes: #{ISSUE_NUMBER}