Fix generate-readme script, refresh examples.json and README.md#703
Open
domdomegg wants to merge 2 commits intoserverless:v3from
Open
Fix generate-readme script, refresh examples.json and README.md#703domdomegg wants to merge 2 commits intoserverless:v3from
domdomegg wants to merge 2 commits intoserverless:v3from
Conversation
Author
Contributor
|
Hello @domdomegg - sorry for late response. This is a massive change and we're currently in the process of rethinking how we should handle the What do you think @mnapoli ? |
Contributor
|
Sorry for the delay, yeah this is a massive PR, I wouldn't be confident merging this, especially with how these files are used to generate pages on serverless.com Maybe if this was all split in smaller pull requests it might be easier? Not sure though 😕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a high-level, this fixes up the examples repository. Currently, both the
npm run docsandnpm run lintscripts don't even run.⚡ This PR
package.jsondefinitions, and generates examples.json from them. This allowsnpm run docsto run successfully.npm run lintto run (but it doesn't pass at the moment, given lots of examples have noncompliant code... but figured fixing all these was for another day)⚠ Potentially breaking changes
framework,authorLink,authorName,authorAvatarfrom examples.json. It isn't used in this repository, and I don't think any of them are necessary for the Serverless examples site but as it's not open-source AFAIK I'm unable to know for sure they're unused.🔮 Future work