fix linux actions#2
Draft
serggl wants to merge 4 commits into
Draft
Conversation
serggl
force-pushed
the
fix_actions
branch
9 times, most recently
from
c55ae8e to
670afa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While working on a test patch to
nodegitI noticed that Github Actions stopped working due to https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/What
This PR updates build steps required for Linux platform, and also adds Node 22 to the build matrix.
Worth mentioning that this also partially rollback changes made with nodegit#1860. Not sure if it's still worth testing against Ubuntu 16.04 which has been EOL since 2021 (like 4 years ago), so I switched it to a more recent (but not edge version) 20.04