Open
Conversation
ephys
requested changes
Mar 21, 2023
Member
ephys
left a comment
ephys
left a comment
There was a problem hiding this comment.
This would only displace the problem, not fix it. If the value includes a double quote, you're going to end up with the same problem
The only way to fix this would be to escape inner quotes
|
Besides the fix, this should also be considered: #592 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sorry and thank you for your sharing.
This PR is about default value.
I have field that uses single quote in default clause,
then it generates
then it causes error.
I've tried
DEFAULT unhex(replace(uuid(),"-","")), but MariaDB converts"to'.I always think thanking you when I use sequelize-auto, please consider this.
Best regards.