fix: convert attributeToSQL to TypeScript and rename it to attributeToSql - #18401

Description of Changes

Fifth and last of the stack re-implementing #17121, stacked on #18428.

Moves attributeToSQL / attributesToSQL out of every dialect's query-generator.js into its query-generator-typescript.internal.ts, renames them to attributeToSql / attributesToSql, and types them.

Closes the last unchecked item of #15533.

No SQL changes. The suites from #18399 produce byte-identical output for all nine dialects, with clean eslint, clean prettier, and clean tsc on both --noEmit and test/tsconfig.json.

What the types say

The old declaration claimed attributesToSQL(attributes: ColumnsDescription, ...), which described none of the real callers — ColumnsDescription has no references, unique, field or onDelete, all of which every dialect reads. That is why the tests needed @ts-expect-error and a hand-written cast.

The new AttributeToSqlColumn documents what the dialects actually read. It is deliberately wider than NormalizedAttributeOptions, because these methods are also called with describeTable output (where type is a raw SQL string) and with hand-written migration definitions. AttributeToSqlInput additionally allows a bare type, which every dialect already normalised to { type }.

Both methods are now declared on the core query generator as a contract each dialect implements, so a dialect drifting from the shared signature is a compile error.

isBinaryStringType joins attributeTypeToDataTypeId (added in #18427) in the core data type utilities, replacing the attribute.type.options?.binary reach-through into a property the base class does not declare.

What typing found

Typing the test file caught two things it was getting wrong:

• deferrable: 'INITIALLY_IMMEDIATE' as a raw string rather than the Deferrable enum.
• A leftover pre-rename option name in the quoteIdentifiers: false block.

Three sets of arguments went away because the compiler proved they could not do anything:

• AttributeToSqlOptions and EscapeOptions share no properties, so mssql and snowflake were handing escape an object it could never read. TypeScript's weak-type check is what surfaced this.
• Several toSql({ dialect }) calls passed an argument no implementation accepts — toSql() takes none in core and in every dialect override.
• db2 called escape(value, undefined, { replacements }) where escape takes two parameters.

All three are removals of dead arguments, confirmed no-ops by the pinned expectations.

The conversion also surfaced the per-dialect bugs now fixed earlier in the stack, in #18427 and #18428, so that this PR stays a pure move and rename.

Second commit: deduplicating attributesToSql

Once all nine implementations sat side by side it was clear how much of them was the same code. Seven of the nine were byte-identical; db2 and mssql differed only by a pre-pass dropping the referential actions of a reference their server will not accept. All nine attributeToSql also opened with the same three lines normalizing their input.

attributesToSql now lives on AbstractQueryGeneratorTypeScript — which is exactly what that class is for — and calls a limitReferentialActions hook that defaults to a no-op. db2 and mssql override it with the rule they already had, structurally unchanged so the diff reads as a move. The normalization becomes an exported normalizeAttributeToSqlColumn.

attributeToSql gains a base implementation that throws, the same shape as createDatabaseQuery, so attributesToSql has something to call. Both declarations leave the hand-written query-generator.d.ts stub, since the class they describe is now typed.

−293 / +136 across 11 files.

One deliberate, behaviour-neutral change: the shared normalization always copies. Only mssql and oracle ever wrote to the attribute they were given, and both already copied, so no output moves — it just makes "attributeToSql does not modify its input" a property of the base rather than something each dialect has to remember. The two regression tests added in #18428 cover it on every dialect.

From review

• AttributeToSqlColumn has no index signature. The old one turned off excess property checking, which is exactly what let the table/tableName/key/foreignKey mismatches fix: give attributeToSQL one way to name the table and the column #18400 fixes compile in the first place — and it also made NormalizedAttributeOptions unassignable, which is why create-table-query.test.ts carried an as any and a "should really be fixed upstream" comment. Both are gone.
• Model is now declared, rather than reached through a cast in oracle and read untyped in mssql.
• db2's replacements read is deleted rather than legitimised. No caller has ever passed it — AttributeToSqlOptions is context, tableOrModel and withoutForeignKeyConstraints.

Notes for review

• attributesToSql result maps are now consistently null-prototype, structurally so after the second commit. mssql and ibmi already used pojo(); the rest built {}. Only the prototype differs and every consumer uses for...in / Object.keys.
• A few non-null assertions on attribute.field remain (mssql, db2, ibmi ENUM branches). These preserve the existing throw rather than papering over it — the "an ENUM without a column name throws" TODO in the test file still describes real behaviour.
• postgres deliberately keeps ! on options.tableOrModel in the comment branch rather than adding a guard: a guard would flip the if/else and emit COMMENT ... instead of throwing, which would be a real SQL change.

List of Breaking Changes

attributeToSQL and attributesToSQL are renamed to attributeToSql and attributesToSql on every dialect's query generator. Query generator methods are not part of the documented public API, but they are reachable.

Replaces #18368, which was opened from a fork before stacked PRs were possible.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Improvements

  • Standardized SQL generation for table and column operations across supported database dialects.
  • Column definitions now consistently handle data types, defaults, nullability, keys, comments, identity columns, positioning, and foreign-key actions.
  • Improved handling of schema-qualified references, self-referential constraints, and dialect-specific column behavior.

• Breaking Changes

  • Query-generation helpers were renamed from attributeToSQL/attributesToSQL to attributeToSql/attributesToSql. Integrations using the previous names must be updated.