check-disk-usage.rb - Option to define minimal free space threshold#166
Open
VeselaHouba wants to merge 1 commit into
Open
check-disk-usage.rb - Option to define minimal free space threshold#166VeselaHouba wants to merge 1 commit into
VeselaHouba wants to merge 1 commit into
Conversation
majormoses
reviewed
Sep 16, 2021
Member
majormoses
left a comment
majormoses
left a comment
There was a problem hiding this comment.
Thank your for your contribution. I think the change makes sense to me although I would like to discuss the defaults further. Look forward to your response.
| description: 'Trigger alarm only if free space on device is below '\ | ||
| 'this threshold (in GB)', | ||
| proc: proc(&:to_f), | ||
| default: 10_000 |
Member
There was a problem hiding this comment.
I would like to better understand where the rationale for this default number came from. I'd imagine this default should be much lower value. 10,000 GB is maybe an appropriate value for a SAN/NAS but I would wager that a double digit number would be more appropriate. Most of my VMs at work have < 100 GB of local storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
No
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
Purpose
Known Compatibility Issues