Handle multiple codes in sequences #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacklul
force-pushed
the
nested-styling
branch
from
1ee4534 to
3745842
Compare
jacklul
force-pushed
the
nested-styling
branch
3 times, most recently
from
3176332 to
e2c01b6
Compare
jacklul
force-pushed
the
nested-styling
branch
from
e2c01b6 to
de5ed7a
Compare
Member
|
Thank you @jacklul. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for handling multiple sequences of ansi codes - preserving the styling until reset code is found.
This addresses #17
Current:
With this PR:
Like in my other PR, PHPUnit passes once the test class is fixed.
TODO:
ANSI codes 22-29 should disable appropriate styling, currently it will not work because ofDonein_arraychecks on 1-9, might need to remove values directly intokenizeor rewrite the styling code into something elseI have an idea how to approach this, will update on that soon