Bold should not affect background color

jacklul · jacklul · commit 41f1df135ece · 2025-02-26T19:57:12.000+01:00
diff --git a/SensioLabs/AnsiConverter/AnsiToHtmlConverter.php b/SensioLabs/AnsiConverter/AnsiToHtmlConverter.php
@@ -120,7 +120,7 @@ protected function convertAnsiToColor($ansi)
             // options: bold => 1, underscore => 4, blink => 5, reverse => 7, conceal => 8
             if (in_array(1, $options) || $hi) { // high intensity equals regular bold
                 $fg += 10;
-                $bg += 10;
+                // bold does not affect background color
             }
 
             if (in_array(4, $options)) {
diff --git a/SensioLabs/AnsiConverter/Tests/AnsiToHtmlConverterTest.php b/SensioLabs/AnsiConverter/Tests/AnsiToHtmlConverterTest.php
@@ -44,7 +44,7 @@ public function getConvertData()
             array('<span style="background-color: darkred; color: darkred">foo</span>', "\e[31;41mfoo\e[m"),
 
             // bright color
-            array('<span style="background-color: red; color: red">foo</span>', "\e[31;41;1mfoo\e[0m"),
+            array('<span style="background-color: darkred; color: red">foo</span>', "\e[31;41;1mfoo\e[0m"),
 
             // carriage returns
             array('<span style="background-color: black; color: white">foobar</span>', "foo\rbar\rfoobar"),

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ protected function convertAnsiToColor($ansi)`
`120`	`120`	`// options: bold => 1, underscore => 4, blink => 5, reverse => 7, conceal => 8`
`121`	`121`	`if (in_array(1, $options) \|\| $hi) { // high intensity equals regular bold`
`122`	`122`	`$fg += 10;`
`123`		`- $bg += 10;`
	`123`	`+ // bold does not affect background color`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`if (in_array(4, $options)) {`