Skip to content

fix: Use starkbank/ecdsa 2.1.0#1111

Merged
tiwarishubham635 merged 5 commits intosendgrid:mainfrom
simoheinonen:allow_starkbank_ecdsa_2
Nov 25, 2024
Merged

fix: Use starkbank/ecdsa 2.1.0#1111
tiwarishubham635 merged 5 commits intosendgrid:mainfrom
simoheinonen:allow_starkbank_ecdsa_2

Conversation

@simoheinonen
Copy link
Contributor

@simoheinonen simoheinonen commented Jul 5, 2024

Fixes

This PR bumps the starkbank/ecdsa version to ^2.1.0 so we get rid of deprecations.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

simoheinonen
simoheinonen commented Jul 5, 2024
View reviewed changes
test/unit/EventWebhookTest.php
self::$SIGNATURE = 'MEUCIGHQVtGj+Y3LkG9fLcxf3qfI10QysgDWmMOVmxG0u6ZUAiE
AyBiXDWzM+uOe5W0JuG+luQAbPIqHh89M15TluLtEZtM=';
self::$BAD_SIGNATURE = 'BADSIGNATURE+Y3LkG9fLcxf3qfI10QysgDWmMOVmxG0u6ZUAiE
AyBiXDWzM+uOe5W0JuG+luQAbPIqHh89M15TluLtEZtM=';
Copy link
Contributor Author

@simoheinonen simoheinonen Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception: missing bytes in DER parse is thrown if this bad signature isn't in the right format

@simoheinonen simoheinonen changed the title Use starkbank/ecdsa 2.1.0 fix: Use starkbank/ecdsa 2.1.0 Jul 5, 2024
@simoheinonen simoheinonen mentioned this pull request Jul 5, 2024
Open
@vincent-lu
Copy link

vincent-lu commented Oct 30, 2024

Can someone please take a look at this PR? Current sendgrid-php is not working with the latest version of starkbank/ecdsa-php library.

See: starkbank/ecdsa-php#23

@54853315
Copy link

54853315 commented Nov 20, 2024

No reviews? Hmm, I think you should email support.

@tiwarishubham635
Copy link
Contributor

tiwarishubham635 commented Nov 20, 2024

Let me check

@tiwarishubham635
Copy link
Contributor

tiwarishubham635 commented Nov 20, 2024

@simoheinonen some tests seem to fail. Can you check once?

@simoheinonen
Copy link
Contributor Author

simoheinonen commented Nov 20, 2024

@simoheinonen some tests seem to fail. Can you check once?

07a92e1 should do it

@simoheinonen
Copy link
Contributor Author

simoheinonen commented Nov 21, 2024

Maybe now?

@tiwarishubham635
Copy link
Contributor

tiwarishubham635 commented Nov 25, 2024

Looks good now. Merging

@tiwarishubham635 tiwarishubham635 merged commit bbc26aa into sendgrid:main Nov 25, 2024
@vincent-lu
Copy link

vincent-lu commented Nov 25, 2024

Thanks guys!

@tectiv3
Copy link

tectiv3 commented Dec 5, 2024

This should've been at least a minor release change.

This package now suddenly requires gmp extension and that change definitely came unexpected.

@vincent-lu
Copy link

vincent-lu commented Mar 10, 2025

Hi @tiwarishubham635 is there any reason why gmp extension is needed here? I checked the sendgrid-php source it doesn't seem to call any gmp related functions?

@tiwarishubham635 tiwarishubham635 mentioned this pull request Apr 11, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecated Property Warnings in EventWebhook Signature Verification with PHP 8.2

5 participants

@simoheinonen @vincent-lu @54853315 @tiwarishubham635 @tectiv3