feat!: Upgrading java-http-client to use apache httpclient5#148
feat!: Upgrading java-http-client to use apache httpclient5#148ryantomlinson95 wants to merge 2 commits intosendgrid:mainfrom
Conversation
sendgrid-java is currently incompatible with apache httpclient5 due to it's dependency on this simplified version of the http client. In order for projects on httpclient5 to use sendgrid-java, this dependency needs to be updated first.
|
I used the official Apache guide for the migration: https://hc.apache.org/httpcomponents-client-5.3.x/migration-guide/migration-to-classic.html, as well as other resources like some of the namespace mappings from here: https://docs.openrewrite.org/recipes/apache/httpclient5/upgradeapachehttpclient_5_classmapping. |
| throw ex; | ||
| } | ||
| uri = buildUri(request.getBaseUri(), request.getEndpoint(), request.getQueryParams()); | ||
| httpGet = new HttpGet(uri.toString()); |
There was a problem hiding this comment.
You can even move the declaration and assignment to the same line, to merge line 170 with 173. The same is valid for the other methods: post, patch, put below.. etc.
Looking good, for the rest. 👍🏻
jkosternl
left a comment
jkosternl
left a comment
There was a problem hiding this comment.
Looking good to me! (I am not a maintainer on this project btw). Hopefully it gets merged and approved by others as well.
|
My suggestion for this PR would be to release it under a new major version, such that it is clear that it is a breaking change for consumers. Then we can also update |
|
Opened a linking issue in the main repo to hopefully make this more visible: sendgrid/sendgrid-java#772 |
|
Is anyone watching this? |
4 participants
Fixes #147
sendgrid-java, specifically the constructor that consumes a
Clientis currently incompatible with apache httpclient5 due to it's dependency on this repository, a simplified version of the http client. In order for projects on httpclient5 to use sendgrid-java, this dependency needs to be updated first.Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.