Remove DisplayQty from CreateSimpleLimit#46
Open
Diegoboca wants to merge 1 commit intosemashkinvg:masterfrom
Open
Remove DisplayQty from CreateSimpleLimit#46Diegoboca wants to merge 1 commit intosemashkinvg:masterfrom
Diegoboca wants to merge 1 commit intosemashkinvg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a new method CreateSimpleLimitIceberg in order to create a new order with a defined displayed quantity.
I remove the field displayQty from the object used in the method CreateSimpleLimit.
I think it is correct to not send the field displayQty when we want to create a simple limit order, because if you try to amend an order with a defined displayQty it becomes an Iceberg order.