Fix taint tracking out of bounds indexing for extension methods with ref-like parameters #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion method with a ref-like parameter
Contributor
|
Hey, could you please re-make the pull request to Master branch? Basically everything that works in VS2015 (or passes tests in Master in case you don't have VS2015) should be in Master branch. Master is always merged into VS2017, not vice versa. This way VS2017 has it's only specific changes. I tried cherry picking from VS2017 to Master for a while and then merging Master into VS2017, but then the commit is doubled in the VS2017 tree :( I tried to change the branch by editing the Pull Request according to https://help.github.com/en/articles/changing-the-base-branch-of-a-pull-request, but then it picks up many more unrelated changes. |
Contributor
Author
|
Sure, I'll take a whack at it real quick. |
Contributor
Author
|
Superseded by #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running taint analysis, calls to extension methods with ref-like (ie.
reforin) parameters can fail with an IndexOutOfRangeException. This is caused by not taking into account the extension methods implicit first parameter.This PR adds a small test and fixes the issue.
I'm tempted to do a more substantial reworking, but this is feels worth fixing on its own.