Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Allow to Specify ENV Vars in the Scan CRD - #49

Merged
rfelber merged 1 commit into
masterfrom
feature/custom-env-vars-in-scans
Jul 2, 2020
Merged

rfelber merged 1 commit into
masterfrom
feature/custom-env-vars-in-scans

Conversation

@J12934

@J12934 J12934 commented Jul 1, 2020

Copy link
Copy Markdown
Member

Closes #48

Needs to be documented, see #47

Can be used like this:

kubectl create secret generic example-secret --from-literal=target=example.com
apiVersion: "execution.experimental.securecodebox.io/v1"
kind: Scan
metadata:
  name: "nmap-from-secret"
spec:
  scanType: "nmap"
  env:
    - name: TARGET
      valueFrom:
        secretKeyRef:
          name: example-secret
          key: target
  parameters:
    - "-p22,443"
    - "$(TARGET)"

@J12934 J12934 added the enhancement New feature or request label Jul 1, 2020
@rfelber
rfelber self-requested a review July 2, 2020 06:36

@rfelber rfelber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🤙

@rfelber
rfelber merged commit c74012a into master Jul 2, 2020
@J12934
J12934 deleted the feature/custom-env-vars-in-scans branch July 23, 2020 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Specification of ENV Vars in the Scan CRD

2 participants