This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Cleanup Unused / Badly named CRD Attributes#140
Merged
Weltraumschaf merged 4 commits intomasterfrom Oct 12, 2020
Merged
Conversation
This is online with the naming of the properties in Kubernetes CronJobs and allows to introduce a `failedJobsHistoryLimit` with consistent nameing.
This has been replaced for a while to just use the ParseDefinitions name. Using the name enables a more direct lookup of the parseType.
J12934
added
documentation
J12934
added a commit
to secureCodeBox/documentation
that referenced
this pull request
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing docs for the CRDs I found some attributes which weren't ideal:
historyLimiton ScheduledScans:Inconsistent with Naming on Kubernetes CronJobs. On ChronJobs its called
successfulJobsHistoryLimitandfailedJobsHistoryLimit. "OurhistoryLimitcurrently only applies to successfulJobs Jobs which makes this naming really confusing as the name would suggest it applies to any job.This change allows us to introduce failedJobsHistoryLimit in the future.
handlesResultsTypein the ParseDefinitionThis isn't used anymore. Instead the name of the ParseDefinition is used. This PR removes this to avoid confusion.