Skip to content

[SCB-Bot] Upgraded sslyze from v4.1.0 to v5.0.2 - #930

Closed
secureCodeBoxBot wants to merge 1 commit into
mainfrom
dependencies/upgrading-sslyze-to-v5.0.2
Closed

secureCodeBoxBot wants to merge 1 commit into
mainfrom
dependencies/upgrading-sslyze-to-v5.0.2

Conversation

@secureCodeBoxBot

Copy link
Copy Markdown
Contributor

This is an automated Pull Request by the SCB-Bot. It upgrades sslyze from v4.1.0 to v5.0.2

Release changes : here

Signed-off-by: secureCodeBoxBot <securecodebox@iteratec.com>
@secureCodeBoxBot secureCodeBoxBot added dependencies Pull requests that update a dependency file scanner Implement or update a security scanner labels Jan 14, 2022
@malexmave

Copy link
Copy Markdown
Member

Hmm. @Ilyesbdlala, any idea why this is not recognized as a duplicate of the previously-closed PR #927 that did the same upgrade?

Leaving open for now to avoid having it re-open a new PR every day, but it's a duplicate of #844.

@J12934

J12934 commented Jan 14, 2022

Copy link
Copy Markdown
Member

@malexmave I think because #844 had the [SCB-Bot] prefix removed from the PR title.
To my understanding the bot looks for pr with the exact same title.

@malexmave

Copy link
Copy Markdown
Member

Yes, but #927 has the exact same title (a PR the bot opened yesterday, which I closed)

@J12934

J12934 commented Jan 14, 2022

Copy link
Copy Markdown
Member

Ah sorry, I didn't read the question right

@Ilyesbdlala

Ilyesbdlala commented Jan 14, 2022 •

Copy link
Copy Markdown
Member

As can be seen here :

echo prExists=$(gh pr list --state open --limit 100 | grep -F "$pullRequestTitle" -c) >> $GITHUB_ENV

The SCB Bot checks the names of the last 100 OPEN PRs to see if the PR already exists. My reasoning there was that If include the closed PRs, the bot may miss an old upgrade PR. Increasing the number of PRs is also a solution, But I thought this was a good middle ground. Let me know if you think differently
So @malexmave since you closed the last PR of this upgrade, the SCB-Bot didn't see it and opened a new one.
You can just keep this one open until we merge #844 to solve the issue.

@malexmave

Copy link
Copy Markdown
Member

Hm. Given the fact that 100 PRs goes back about 3 months at our current pace, even when including closed PRs, it may be worthwhile to include them, as it allows us to keep the list of PRs limited to those that we are actually working on. Or, if it is possible, the bot could instead search for a PR with a specific name / by its own bot user / ... to make it more robust. It's not a high priority, but may be a nice to have feature.

@J12934

J12934 commented Mar 16, 2022

Copy link
Copy Markdown
Member

Was already updated with #844

@J12934 J12934 closed this Mar 16, 2022
@J12934
J12934 deleted the dependencies/upgrading-sslyze-to-v5.0.2 branch July 7, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Changes requiring a major release dependencies Pull requests that update a dependency file scanner Implement or update a security scanner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants