Skip to content

Fix/nuclei without template cache pvc#858

Merged
J12934 merged 2 commits intomainfrom
fix/nuclei-without-template-cache-pvc
Dec 8, 2021
Merged

Fix/nuclei without template cache pvc#858
J12934 merged 2 commits intomainfrom
fix/nuclei-without-template-cache-pvc

Conversation

@J12934
Copy link
Copy Markdown
Member

@J12934 J12934 commented Dec 6, 2021 •
edited
Loading

Description

Related to secureCodeBox/documentation#166

Noticed that there was still a bug in the chart when disabling the template cache.
Also added docs on how to actually disable it.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

J12934 added 2 commits December 6, 2021 16:53
@J12934
Only include -no-update-templates option when using the templateCache
ef451b9 
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934
Add docs on how to install nuclei without the template cache
79aa0dd 
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 added bug Bugs documentation Improvements or additions to documentation labels Dec 6, 2021
@J12934 J12934 self-assigned this Dec 6, 2021
@malexmave
Copy link
Copy Markdown
Member

malexmave commented Dec 6, 2021

Did you also check the rest of the Nuclei documentation (since you are closing the general issue for sanity-checking the docs with this PR), or is this only for the one specific problem related to template caches (in which case we should leave the issue open)?

@J12934
Copy link
Copy Markdown
Member Author

J12934 commented Dec 7, 2021 •
edited
Loading

Did you also check the rest of the Nuclei documentation (since you are closing the general issue for sanity-checking the docs with this PR), or is this only for the one specific problem related to template caches (in which case we should leave the issue open)?

Ah nope, good point 👍
(Changed the description)

@Ilyesbdlala
Copy link
Copy Markdown
Member

Ilyesbdlala commented Dec 8, 2021 •
edited
Loading

installing nuclei with the following works. templates are downloaded.

helm install nuclei secureCodeBox/nuclei --set="nucleiTemplateCache.enabled=false"

However installing it normally (with the template cache enabled ) results in forever pending pods. Does that mean that my cluster created with "kind" simply doesn't support the ReadOnlyMany volume type you mention. Or is this not the expected behaviour?

NAME                                          READY   STATUS    RESTARTS   AGE  
nuclei-update-initial-template-cache-2lrnt    0/1     Pending   0          74m  
nuclei-update-template-cache-27316200-h6dbz   0/1     Pending   0          8m46s

@J12934
Copy link
Copy Markdown
Member Author

J12934 commented Dec 8, 2021 •
edited
Loading

@Ilyesbdlala yup probably, you can check by running

kubectl describe nuclei-content-claim

This should include a error description in the pvc.

Note: the 3.4.0 helm chart currently also had some issue with the security context, might also be related and blocking your containers from being executed

@Ilyesbdlala
Copy link
Copy Markdown
Member

Ilyesbdlala commented Dec 8, 2021

Just for reference, the command the view the PersistentVolumeClaim was
kubectl describe pvc nuclei-content-claim
And yes, my cluster unfortunately doesn't support ReadOnlyMany volumes.

Type     Reason                Age                    From                                                                                                Message
  ----     ------                ----                   ----                                                                                                -------
  Normal   WaitForFirstConsumer  28m                    persistentvolume-controller                                                                         waiting for first consumer to be created before binding
  Normal   Provisioning          12m (x7 over 28m)      rancher.io/local-path_local-path-provisioner-547f784dff-cw2sb_befcd024-db22-44bd-a681-d8162826802c  External provisioner is provisioning volume for claim "default/nuclei-content-claim"
  Warning  ProvisioningFailed    12m (x7 over 28m)      rancher.io/local-path_local-path-provisioner-547f784dff-cw2sb_befcd024-db22-44bd-a681-d8162826802c  failed to provision volume with StorageClass "standard": Only support ReadWriteOnce access mode
  Normal   ExternalProvisioning  3m10s (x103 over 28m)  persistentvolume-controller                                                                         waiting for a volume to be created, either by external provisioner "rancher.io/local-path" or manually created by system administrator

works well otherwise.

@J12934 J12934 merged commit 2724fde into main Dec 8, 2021
@J12934 J12934 deleted the fix/nuclei-without-template-cache-pvc branch December 8, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ilyesbdlala Ilyesbdlala Ilyesbdlala approved these changes

@malexmave malexmave Awaiting requested review from malexmave

Assignees

@J12934 J12934

Labels

bug Bugs documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@J12934 @malexmave @Ilyesbdlala