Skip to content

Upgraded sslyze from v4.1.0 to v5.0.2 - #844

Merged
J12934 merged 36 commits into
mainfrom
dependencies/upgrading-sslyze-to-v5.0.0
Mar 16, 2022
Merged

J12934 merged 36 commits into
mainfrom
dependencies/upgrading-sslyze-to-v5.0.0

Conversation

@secureCodeBoxBot

@secureCodeBoxBot secureCodeBoxBot commented Nov 27, 2021 •

Copy link
Copy Markdown
Contributor

This is Pull Request upgrades sslyze from v4.1.0 to v5.0.2

  • We now use a custom Docker image for SSLyze to work around some limitations of the software. The switch will be performed automatically when you update the scanner using Helm, you do not need to perform any manual actions.

  • SSLyze changed its JSON output schema, which will be reflected in the raw output of the scanner. You can find the new output schema here. The secureCodeBox findings format remains unchanged, so if you rely only on the findings, not the raw output, you will not need to make any changes based on this.

  • BREAKING : SSLyze removed or replaced a number of parameters. In particular:
    --regular was replaced with --mozilla_config {modern,intermediate,old}
    --resum_rate was replaced with --resum_attempts

  • New commmand-line options:
    --elliptic_curves Test a server for supported elliptic curves.

  • BREAKING: Public-Key-Pins headers are no longer checked by SSLyze, as the pinning feature has been removed from most browsers

  • This release also includes other changes that don't modify SCB's functionality. Info can be found in the link below

Official Changelogs: 5.0.0, 5.0.1 (contains another parameter change), 5.0.2

Signed-off-by: secureCodeBoxBot <securecodebox@iteratec.com>
@secureCodeBoxBot secureCodeBoxBot added dependencies Pull requests that update a dependency file scanner Implement or update a security scanner labels Nov 27, 2021
@malexmave

Copy link
Copy Markdown
Member

Okay, I assume the problem with the changelog here is that a star (*) is interpreted as a wildcard file operator somehow? Paging @Ilyesbdlala :).

@malexmave
malexmave marked this pull request as draft November 29, 2021 12:23
@malexmave

malexmave commented Nov 29, 2021 •

Copy link
Copy Markdown
Member

Converting this to draft. The update changed the JSON format, the reason the CI runs is probably that the unit tests are unaffected by this change and I am not sure that integration tests exist for this. We'll have to take a detailed look at this change before merging it.

@Ilyesbdlala

Copy link
Copy Markdown
Member

Okay, I assume the problem with the changelog here is that a star (*) is interpreted as a wildcard file operator somehow? Paging @Ilyesbdlala :).

It does seems so. I didn't know this was a function in the "GitHub's" Markdown. I'll look into it.
Actual release log : here

Converting this to draft. The update changed the JSON format, the reason the CI runs is probably that the unit tests are unaffected by this change and I am not sure that integration tests exist for this. We'll have to take a detailed look at this change before merging it.

By sslyze, the appVersion tag is actually overwitten by scanner.image.tag in the values.yaml file as I mentioned here #429.
Since this time the docker image 5.0.0 is released. We can simply make the necessary changes to the parser and upgrade sslyze directly to 5.0.0.

Ilyesbdlala and others added 2 commits December 21, 2021 09:39
This is done so the image version defaults to appVersion

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
@Ilyesbdlala Ilyesbdlala self-assigned this Dec 21, 2021
@Ilyesbdlala Ilyesbdlala changed the title [SCB-Bot] Upgraded sslyze from v4.1.0 to v5.0.0 [SCB-Bot] Upgraded sslyze from v4.1.0 to v5.0.1 Dec 21, 2021
Ilyesbdlala and others added 16 commits December 22, 2021 13:36
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
This is done to include the Helm docs fix

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
sslyze json tree is different with 5.0.0.
This resolves the issue for scan_result and server_location attributes

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
   * Equal values of version 5.0.1

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
* This is done to avoid non zero exit codes from sslyze

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
@Ilyesbdlala
Ilyesbdlala marked this pull request as ready for review December 29, 2021 13:55
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala changed the title [SCB-Bot] Upgraded sslyze from v4.1.0 to v5.0.1 [SCB-Bot] Upgraded sslyze from v4.1.0 to v5.0.2 Jan 4, 2022
Ilyesbdlala and others added 5 commits January 4, 2022 09:00
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
* It's an old test, that we can't reproduce

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This is done to include ZAP CI Test Update

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@malexmave

malexmave commented Jan 12, 2022 •

Copy link
Copy Markdown
Member

Does this PR change anything about the external interface of this scanner from the point of view of an SCB user? I.e.,

  • How it is parameterized (in a non-backwards-compatible way)
  • Remove or change the meaning of part of the finding format
  • ... basically anything that would require users to take manual action when updating to this version?

I think it does not, but you are the expert, @Ilyesbdlala.

Update: Hmm, actually, some of the parameters changed and were removed, so this probably qualifies as a breaking change with a major release according to #926. We should make sure this and the Gitleaks PR are released at the same time so we don't have back-to-back major releases because of these dependencies.

Can you edit the original post (first message in the PR) and give a summary of the changes there, so that people can easily find what they need to change (probably mostly replacing a few parameters)?

@malexmave malexmave added the breaking Changes requiring a major release label Jan 12, 2022
@malexmave malexmave changed the title [SCB-Bot] Upgraded sslyze from v4.1.0 to v5.0.2 Upgraded sslyze from v4.1.0 to v5.0.2 Jan 12, 2022
malexmave
malexmave previously approved these changes Jan 12, 2022
@malexmave

Copy link
Copy Markdown
Member

Also, can anyone see the findings that Snyk complains about for this PR? I don't have an account there.

@J12934

J12934 commented Jan 12, 2022

Copy link
Copy Markdown
Member

@malexmave seems like its being rate limited, i'd be ok ignoring these errors

Screenshot 2022-01-12 at 13 15 44

@Weltraumschaf Weltraumschaf added the planned Issues we will do in the next sprint. label Mar 2, 2022
Ilyesbdlala and others added 3 commits March 9, 2022 13:04
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This is done to add the ZAP-Advanced CI Fix
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
This is done to include the fix to semgrep integration-tests

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>

@Ilyesbdlala Ilyesbdlala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproved the PR. That is since no changes have been made since @malexmave review.

@J12934
J12934 merged commit 87706a3 into main Mar 16, 2022
@J12934
J12934 deleted the dependencies/upgrading-sslyze-to-v5.0.0 branch March 16, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Changes requiring a major release dependencies Pull requests that update a dependency file planned Issues we will do in the next sprint. scanner Implement or update a security scanner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants