Repository navigation
Upgraded sslyze from v4.1.0 to v5.0.2 - #844
Conversation
Signed-off-by: secureCodeBoxBot <securecodebox@iteratec.com>
|
Okay, I assume the problem with the changelog here is that a star ( |
|
Converting this to draft. The update changed the JSON format, the reason the CI runs is probably that the unit tests are unaffected by this change and I am not sure that integration tests exist for this. We'll have to take a detailed look at this change before merging it. |
It does seems so. I didn't know this was a function in the "GitHub's" Markdown. I'll look into it.
By sslyze, the appVersion tag is actually overwitten by |
This is done so the image version defaults to appVersion Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
This is done to include the Helm docs fix Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
sslyze json tree is different with 5.0.0. This resolves the issue for scan_result and server_location attributes Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
* Equal values of version 5.0.1 Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
* This is done to avoid non zero exit codes from sslyze Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
* It's an old test, that we can't reproduce Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This is done to include ZAP CI Test Update Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
|
Does this PR change anything about the external interface of this scanner from the point of view of an SCB user? I.e.,
I think it does not, but you are the expert, @Ilyesbdlala. Update: Hmm, actually, some of the parameters changed and were removed, so this probably qualifies as a breaking change with a major release according to #926. We should make sure this and the Gitleaks PR are released at the same time so we don't have back-to-back major releases because of these dependencies. Can you edit the original post (first message in the PR) and give a summary of the changes there, so that people can easily find what they need to change (probably mostly replacing a few parameters)? |
|
Also, can anyone see the findings that Snyk complains about for this PR? I don't have an account there. |
|
@malexmave seems like its being rate limited, i'd be ok ignoring these errors |
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This is done to add the ZAP-Advanced CI Fix
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
This is done to include the fix to semgrep integration-tests Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala
left a comment
There was a problem hiding this comment.
Reapproved the PR. That is since no changes have been made since @malexmave review.

This is Pull Request upgrades sslyze from v4.1.0 to v5.0.2
We now use a custom Docker image for SSLyze to work around some limitations of the software. The switch will be performed automatically when you update the scanner using Helm, you do not need to perform any manual actions.
SSLyze changed its JSON output schema, which will be reflected in the raw output of the scanner. You can find the new output schema here. The secureCodeBox findings format remains unchanged, so if you rely only on the findings, not the raw output, you will not need to make any changes based on this.
BREAKING : SSLyze removed or replaced a number of parameters. In particular:
--regularwas replaced with--mozilla_config {modern,intermediate,old}--resum_ratewas replaced with--resum_attemptsNew commmand-line options:
--elliptic_curvesTest a server for supported elliptic curves.BREAKING: Public-Key-Pins headers are no longer checked by SSLyze, as the pinning feature has been removed from most browsers
This release also includes other changes that don't modify SCB's functionality. Info can be found in the link below
Official Changelogs: 5.0.0, 5.0.1 (contains another parameter change), 5.0.2