Repository navigation
Build Scanners With New Make Targets - #712
Conversation
I simplified the build steps for scanners by removing the docker build and push action and use the makefile targets instead. This also made the docker meta action unnecessar. Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I added ssh-scan to matrix build and moved the integration tests Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I moved sslyze to the new makefile job and moved the integration tests as well Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
|
@fuhrmeistery what's the reason for overwriting the Only if there are scanner specific changes required for deployment (e.g. |
@EndPositive The reason is that we want to move the integration tests for the scanners into the scanner directory to have all scanner related files in one place. The goal is to update the |
|
Awesome, makes sense! |
we decided the general test for sslyze and the test of cascading scans in general is sufficient Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
edd9d0d to
39cc147
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
39cc147 to
f063ffc
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
1736b08 to
422a0df
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
f66166b to
4b3d91c
Compare
Prior we introduced finding valitation for our expected findings format. This commit ensures that all parsers are throwing an error on invalid formats Previously changed make targets adding this to a specific scanner are reverted as well Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
49a8ddd to
c5b77bf
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Like with sslyze we decided to disable the cascading test for ncrack and rely on the test of cascading scans in general Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
a1e566c to
44eb52d
Compare
I removed the old build job for third party scanners because it is not needed anymore Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
44eb52d to
44d4501
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
fail-fast causes all remaining jobs of this matrix to be canceld if one job fails. To see the impact of the change on the others it might be better to let these finish as well. Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I removed these steps and variable definitions because they are already handled by make by default Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@protonmail.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@protonmail.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@protonmail.com>
This PR, if applied, will