Skip to content

Updated nikto to latest release v2.5.0#668

Merged
Weltraumschaf merged 10 commits intomainfrom
dependencies/updating-nikto-to-2.5.0
Feb 16, 2022
Merged

Updated nikto to latest release v2.5.0#668
Weltraumschaf merged 10 commits intomainfrom
dependencies/updating-nikto-to-2.5.0

Conversation

@rfelber
Copy link
Copy Markdown
Member

@rfelber rfelber commented Sep 22, 2021 •
edited by Ilyesbdlala
Loading

Description

This PR if applied updates the nikto scanner to the latest release v2.5.0.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@rfelber
Updating nikto to latest release v2.5.0
7d764e9 
Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
@rfelber rfelber added scanner Implement or update a security scanner dependencies Pull requests that update a dependency file labels Sep 22, 2021
@rfelber rfelber added this to the v3.2.0 milestone Sep 22, 2021
@rfelber rfelber self-assigned this Sep 22, 2021
rfelber and others added 2 commits September 22, 2021 22:26
@rfelber
Updating integration test
e48f086 
due to increased findings

Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
@SebieF
Merge remote-tracking branch 'origin/main' into dependencies/updating…
1ec6e5b 
…-nikto-to-2.5.0
@J12934
Copy link
Copy Markdown
Member

J12934 commented Sep 24, 2021

Duplicate of #617 ?
Anybody have thoughts on which PR should be preferred?

@Ilyesbdlala
Copy link
Copy Markdown
Member

Ilyesbdlala commented Sep 24, 2021

Duplicate of #617 ?
Anybody have thoughts on which PR should be preferred?

It is a duplicate. However I did #617 before we changed how the nikto docker image is built and implemented the new makefiles. So my pull request is no longer relevant. I think it's better if I close #617 without merging and continue the issue here.
The problem is, my pull request got outdated because we found that the 2.5.0 nikto version has some bugs ( we opened an issue here sullo/nikto#742). So We will have to wait on the upgrade until that is resolved.

@Ilyesbdlala
Update Nikto examples
40946bf 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Updated Nikto scanner's test files and jest snapshots
ade8758 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala mentioned this pull request Sep 27, 2021
Closed
3 tasks
@Ilyesbdlala Ilyesbdlala linked an issue Sep 27, 2021 that may be closed by this pull request
Nikto parser unable to handle error cases #604
Closed
@rfelber rfelber modified the milestones: v3.2.0, v3.3.0 Oct 8, 2021
@Ilyesbdlala
Merge branch 'main' into dependencies/updating-nikto-to-2.5.0
1f9c127 
Updates an Old PR to check for new changes
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Updated testfiles and snapshots of nikto-2.5.0
bd499aa 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Updated examples of nikto-2.5.0
10dc5e2 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Added an unresolvable-host parser unit-test for nikto-2.5.0
1958fe6 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala marked this pull request as ready for review January 11, 2022 11:01
@Ilyesbdlala
Copy link
Copy Markdown
Member

Ilyesbdlala commented Jan 11, 2022 •
edited
Loading

sullo/nikto#742 has been resolved. Nikto can now be upgraded to 2.5.0
closes #604 (unresolvable host no longer crash the parser, instead they have empty findings)

@Ilyesbdlala Ilyesbdlala self-assigned this Jan 12, 2022
@Ilyesbdlala
Merge branch 'main' into dependencies/updating-nikto-to-2.5.0
1392f68 
This is done to resolve merge conflicts

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Weltraumschaf Weltraumschaf merged commit 1e6957a into main Feb 16, 2022
@Weltraumschaf Weltraumschaf deleted the dependencies/updating-nikto-to-2.5.0 branch February 16, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Weltraumschaf Weltraumschaf Weltraumschaf approved these changes

@RamiSouai RamiSouai RamiSouai approved these changes

Assignees

@rfelber rfelber

@Ilyesbdlala Ilyesbdlala

Labels

dependencies Pull requests that update a dependency file scanner Implement or update a security scanner

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

Nikto parser unable to handle error cases

6 participants

@rfelber @J12934 @Ilyesbdlala @Weltraumschaf @RamiSouai @SebieF