Conversation
Test against the latest tag wont work as this version doesnt contain docker healthchecks yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added API tests.
The tests start the docker-compose stack and will then start securityTest and assert that the detected findings match the expectations.
Notes
developtag. The build uses a build matrix for the docker tag and can be expended for more tags by commenting out this line:secureCodeBox/.travis.yml
Line 7 in 7cc799d
docker-compose upwill now wait for the engine healthcheck to complete before starting the scanner. This makes waiting for the engine to start up trivial, but unfortunatly also meant that i had to downgrade thedocker-composefile version to2.1, as3doesn't supportconditionalsindepends_onanymore.