Updated nikto scanner to v2.5.0 (closes #604) #617
Closed
Ilyesbdlala wants to merge 13 commits intomainfrom
Closed
Updated nikto scanner to v2.5.0 (closes #604) #617Ilyesbdlala wants to merge 13 commits intomainfrom
Ilyesbdlala wants to merge 13 commits intomainfrom
Conversation
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
rfelber
changed the title
This is done to make sure that codeclimate/total-coverage is consistent between branches Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
JohannesZahn
requested changes
Sep 3, 2021
Contributor
There was a problem hiding this comment.
With everything else we'll have to wait on more feedback on sullo/nikto#742
Co-authored-by: Johannes Zahn <johannes.zahn@iteratec.com> Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…s each This is file has to be short, since it's presented in the docs website as an example. Co-authored-by: Johannes Zahn <johannes.zahn@iteratec.com> Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
nigthknight
requested changes
Sep 13, 2021
| with: | ||
| repository: "sullo/nikto" | ||
| path: nikto | ||
| ref: nikto-2.5.0 |
Member
There was a problem hiding this comment.
I think it would be great to create a variable containing the desired version to minimize the locations we have to update for a new release
| expect(findings).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test("parses no web server found finding correctly", async () => { |
Member
There was a problem hiding this comment.
Suggested change
| test("parses no web server found finding correctly", async () => { | |
| test("parses 'no web server found' finding correctly", async () => { |
I think this could improve readability
3 tasks
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the nikto scanner to 2.5.0. The main reason for it is to solve the issue the scanner has, when parsing findings from an unresolvable host (Issue #604).
Updating also results into more findings.
It should be noted that with this PR, Nikto scanner relies on the github repo having a 2.5.0 branch. The
ci.yamlhas to be changed if the 2.5.0 becomes in the release branch.Checklist
npm testruns for the whole project.