Skip to content

Cascading Scans bugfixing - #583

Merged
J12934 merged 3 commits into
secureCodeBox:mainfrom
EndPositive:cascading-scans-bugfixing
Aug 9, 2021
Merged

J12934 merged 3 commits into
secureCodeBox:mainfrom
EndPositive:cascading-scans-bugfixing

Conversation

@EndPositive

@EndPositive EndPositive commented Aug 9, 2021 •

Copy link
Copy Markdown
Contributor

Description

  • 0471226 fixes a bug where if a single rule would be applied to two findings, it would only be templated using the first finding.
  • 545898e simple cleanup.
  • 5896910 fixes a bug where the new secureCodeBox.io annotations (such as parent-scan, matched-finding, and chain) would be overwritten by the parent's annotations (if inheritAnnotations was enabled; default).

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

…ng rule between matched findings

Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
…urecodebox annotations always override those of the parent.

Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
@rfelber rfelber added scanner Implement or update a security scanner bug Bugs labels Aug 9, 2021

@J12934 J12934 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a nasty bug, good catch 👍

@J12934
J12934 enabled auto-merge August 9, 2021 15:30
@J12934
J12934 merged commit e158169 into secureCodeBox:main Aug 9, 2021
@EndPositive
EndPositive deleted the cascading-scans-bugfixing branch August 9, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs scanner Implement or update a security scanner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants