Cascading scans codeclimate#482
Merged
J12934 merged 3 commits intosecureCodeBox:mainfrom Jun 9, 2021
EndPositive:maintanance/cascading-scans-codeclimate
Merged
Cascading scans codeclimate#482J12934 merged 3 commits intosecureCodeBox:mainfrom EndPositive:maintanance/cascading-scans-codeclimate
J12934 merged 3 commits intosecureCodeBox:mainfrom
EndPositive:maintanance/cascading-scans-codeclimate
Conversation
…itive complexity Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
…lexity Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
EndPositive
changed the title
6 tasks
J12934
approved these changes
Jun 9, 2021
Member
J12934
left a comment
J12934
left a comment
There was a problem hiding this comment.
Nice 🚀
Will merge this on mainas this is a refactoring which doesn't change the hooks behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the codeclimate issues that the cascading scan hook was having.
Checklist
npm testruns for the whole project.