Skip to content

Cascading Scans: rename directory & docker containers#481

Merged
J12934 merged 11 commits intosecureCodeBox:v3from
EndPositive:maintanance/rename_cascading_scans
Jun 10, 2021
Merged

Cascading Scans: rename directory & docker containers#481
J12934 merged 11 commits intosecureCodeBox:v3from
EndPositive:maintanance/rename_cascading_scans

Conversation

@EndPositive
Copy link
Copy Markdown
Contributor

@EndPositive EndPositive commented Jun 9, 2021

Description

This PR renames declarative-subsequent-scans to cascading-scans wherever possible.
This PR is part of the maintenance for v3.0.0 as described in #293.

This PR will not introduce the hook- prefix for the docker container as described in #471 .

Todo

  • Rename docker containers, directory name, and helm chart name.
  • Rename code references.
  • Rename test usages.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
@EndPositive EndPositive marked this pull request as ready for review June 9, 2021 09:18
@EndPositive
Copy link
Copy Markdown
Contributor Author

Codeclimate isn't happy, but the errors are unrelated to this PR.

@J12934
Copy link
Copy Markdown
Member

J12934 commented Jun 9, 2021

Awesome 🚀 Will take a look at it later.

Codeclimate isn't happy, but the errors are unrelated to this PR.

Yeah it sometimes does that 😕
We can still merge it, no problem

@EndPositive
Copy link
Copy Markdown
Contributor Author

Codeclimate is fixed in #482 !

@J12934
Copy link
Copy Markdown
Member

J12934 commented Jun 9, 2021

This should now be rebased / have main merged into it to apply the fixes for code climate.

@EndPositive EndPositive changed the base branch from main to v3 June 9, 2021 21:12
@EndPositive
Copy link
Copy Markdown
Contributor Author

Done 😃

J12934 added 2 commits June 10, 2021 09:32
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 assigned J12934 and unassigned J12934 Jun 10, 2021
@J12934 J12934 added breaking Changes requiring a major release maintenance labels Jun 10, 2021
@J12934 J12934 added this to the v3.0.0 milestone Jun 10, 2021
@J12934 J12934 merged commit 5f77f37 into secureCodeBox:v3 Jun 10, 2021
@EndPositive EndPositive deleted the maintanance/rename_cascading_scans branch October 22, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Changes requiring a major release maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants