Skip to content

Support DefectDojo Parsers that rely on file endings (e.g. Nikto JSON Parser and Generic JSON Parser) - #437

Merged
J12934 merged 9 commits into
mainfrom
defectdojo_generic_parser_integration
May 20, 2021
Merged

J12934 merged 9 commits into
mainfrom
defectdojo_generic_parser_integration

Conversation

@JohannesZahn

@JohannesZahn JohannesZahn commented May 20, 2021 •

Copy link
Copy Markdown
Contributor

Description

If no explicit parser is specified for a scan, a Generic Parser will be selected and instead of the raw scan results the generic findings.json will be sent to DefectDojo.

This will currently not work for the generic case, because the SecureCodeBox Parser in DefectDojo is not yet released and also it is still up for debate if the generic JSON Parser should be used instead.

Still it would be beneficial to merge the PR as it enables both approaches and the code does not work any less than now, as it still works for the parsers that are already implemented. Now however the logic for selecting the generic parser and downloading the findings.json enables the second feature introduced by this PR:

File names (for the generic as well as specific parsers) are now sent to DefectDojo, so parsers that rely on filenames like nikto, as well as the generic json parser can now be selected. This therefore closes #432.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@JohannesZahn
JohannesZahn requested review from J12934 and rfelber May 20, 2021 10:11
@JohannesZahn JohannesZahn changed the title Defectdojo generic parser integration DD generic parser integration + Passing Filenames to DD May 20, 2021
@JohannesZahn JohannesZahn changed the title DD generic parser integration + Passing Filenames to DD DD generic parser integration (including passing file names to DD) May 20, 2021
@rfelber rfelber added defectdojo All issues regarding the DefectDojo Integration persistence Implement or update a persistence store labels May 20, 2021
@JohannesZahn JohannesZahn changed the title DD generic parser integration (including passing file names to DD) Support DefectDojo Parsers that rely on file endings (e.g. Nikto JSON Parser and Generic JSON Parser) May 20, 2021
@JohannesZahn
JohannesZahn marked this pull request as ready for review May 20, 2021 12:04
@J12934
J12934 merged commit cfecb06 into main May 20, 2021
@J12934
J12934 deleted the defectdojo_generic_parser_integration branch May 20, 2021 13:24
@rfelber rfelber added the hook Implement or update a hook label May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

defectdojo All issues regarding the DefectDojo Integration hook Implement or update a hook persistence Implement or update a persistence store

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Defectdojo Hook to use parsers that rely on file names

3 participants