Repository navigation
Support DefectDojo Parsers that rely on file endings (e.g. Nikto JSON Parser and Generic JSON Parser) - #437
Merged
Merged
Conversation
…b.com/secureCodeBox/secureCodeBox into defectdojo_generic_parser_integration
JohannesZahn
marked this pull request as ready for review
May 20, 2021 12:04
J12934
approved these changes
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If no explicit parser is specified for a scan, a Generic Parser will be selected and instead of the raw scan results the generic findings.json will be sent to DefectDojo.
This will currently not work for the generic case, because the SecureCodeBox Parser in DefectDojo is not yet released and also it is still up for debate if the generic JSON Parser should be used instead.
Still it would be beneficial to merge the PR as it enables both approaches and the code does not work any less than now, as it still works for the parsers that are already implemented. Now however the logic for selecting the generic parser and downloading the findings.json enables the second feature introduced by this PR:
File names (for the generic as well as specific parsers) are now sent to DefectDojo, so parsers that rely on filenames like nikto, as well as the generic json parser can now be selected. This therefore closes #432.
Checklist
npm testruns for the whole project.