operator: make minio endpoint cluster domain configurable - #3702
Merged
J12934 merged 1 commit intoJun 29, 2026
Merged
Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
The operator hardcoded `.svc.cluster.local` when building the in-cluster Minio endpoint (RELEASE-minio.NAMESPACE.svc.cluster.local), so the operator can't reach Minio on clusters configured with a custom cluster domain (e.g. via kubelet's --cluster-domain). Adds a `clusterDomain` value (default `cluster.local`, preserving existing behavior) and uses it when building the endpoint. Fixes secureCodeBox#2895 Signed-off-by: Amit Mishra <amit.mishra.eee21@itbhu.ac.in>
amitmishra11
force-pushed
the
fix/operator-configurable-cluster-domain-2895
branch
from
June 27, 2026 14:32
832d9ee to
030acbb
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #2895
Problem
The operator's Helm chart hardcodes
.svc.cluster.localwhen building the in-cluster Minio endpoint:On clusters configured with a non-default cluster domain (e.g. kubelet started with
--cluster-domain=mycorp.internal), this hostname doesn't resolve, and the operator can't reach its own bundled Minio.Fix
Adds a
clusterDomainvalue tooperator/values.yaml, defaulting tocluster.local(no change to existing behavior), and uses it in the endpoint template instead of the hardcoded literal.Note on prior attempt
I saw that #2921 previously tried to address this issue and was closed — that PR referenced a nonexistent image and changed the Minio image tag/version instead of actually touching the hardcoded endpoint, so it didn't fix the reported problem. This PR only touches the
clusterDomainvalue and the one template line that builds the endpoint string; it doesn't change the Minio image, tag, or any chart dependency.Testing
helm-unittestcase (allows overriding the cluster domain used for the minio endpoint) assertingS3_ENDPOINTreflects a customclusterDomain.configures manager deployment for miniotest still passes with the default value (cluster.local), preserving backward compatibility — and verified it actually catches a regression by temporarily breaking the default and re-running.helm templateboth with and without--set clusterDomain=...to confirm the output is correct in both cases:operator/README.md's generated values table with the newclusterDomainentry.I wasn't able to verify this against a live cluster with a custom cluster domain, but the chart-level behavior (default preserved, override applied) is covered by the test above.