Skip to content

operator: make minio endpoint cluster domain configurable - #3702

Merged
J12934 merged 1 commit into
secureCodeBox:mainfrom
amitmishra11:fix/operator-configurable-cluster-domain-2895
Jun 29, 2026
Merged

operator: make minio endpoint cluster domain configurable#3702
J12934 merged 1 commit into
secureCodeBox:mainfrom
amitmishra11:fix/operator-configurable-cluster-domain-2895

Conversation

@amitmishra11

Copy link
Copy Markdown
Contributor

Fixes #2895

Problem

The operator's Helm chart hardcodes .svc.cluster.local when building the in-cluster Minio endpoint:

operator/templates/manager/manager.yaml:78
value: "{{ .Release.Name }}-minio.{{ .Release.Namespace }}.svc.cluster.local"

On clusters configured with a non-default cluster domain (e.g. kubelet started with --cluster-domain=mycorp.internal), this hostname doesn't resolve, and the operator can't reach its own bundled Minio.

Fix

Adds a clusterDomain value to operator/values.yaml, defaulting to cluster.local (no change to existing behavior), and uses it in the endpoint template instead of the hardcoded literal.

Note on prior attempt

I saw that #2921 previously tried to address this issue and was closed — that PR referenced a nonexistent image and changed the Minio image tag/version instead of actually touching the hardcoded endpoint, so it didn't fix the reported problem. This PR only touches the clusterDomain value and the one template line that builds the endpoint string; it doesn't change the Minio image, tag, or any chart dependency.

Testing

  • Added a helm-unittest case (allows overriding the cluster domain used for the minio endpoint) asserting S3_ENDPOINT reflects a custom clusterDomain.
  • Confirmed the existing configures manager deployment for minio test still passes with the default value (cluster.local), preserving backward compatibility — and verified it actually catches a regression by temporarily breaking the default and re-running.
  • Rendered the chart directly with helm template both with and without --set clusterDomain=... to confirm the output is correct in both cases:
    $ helm template operator --set clusterDomain=mycorp.internal --show-only templates/manager/manager.yaml | grep S3_ENDPOINT
    value: "release-name-minio.default.svc.mycorp.internal"
    
    $ helm template operator --show-only templates/manager/manager.yaml | grep S3_ENDPOINT
    value: "release-name-minio.default.svc.cluster.local"
    
  • Updated operator/README.md's generated values table with the new clusterDomain entry.

I wasn't able to verify this against a live cluster with a custom cluster domain, but the chart-level behavior (default preserved, override applied) is covered by the test above.

@netlify

netlify Bot commented Jun 27, 2026

Copy link
Copy Markdown

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 030acbb
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/6a3fdf190585e9000841f2bf

The operator hardcoded `.svc.cluster.local` when building the in-cluster
Minio endpoint (RELEASE-minio.NAMESPACE.svc.cluster.local), so the
operator can't reach Minio on clusters configured with a custom cluster
domain (e.g. via kubelet's --cluster-domain).

Adds a `clusterDomain` value (default `cluster.local`, preserving
existing behavior) and uses it when building the endpoint.

Fixes secureCodeBox#2895

Signed-off-by: Amit Mishra <amit.mishra.eee21@itbhu.ac.in>
@amitmishra11
amitmishra11 force-pushed the fix/operator-configurable-cluster-domain-2895 branch from 832d9ee to 030acbb Compare June 27, 2026 14:32
@Weltraumschaf Weltraumschaf moved this from Triage to To Review in secureCodeBox Jun 29, 2026

@J12934 J12934 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks :)

@github-project-automation github-project-automation Bot moved this from To Review to Reviewer Approved in secureCodeBox Jun 29, 2026
@J12934
J12934 merged commit 67d6714 into secureCodeBox:main Jun 29, 2026
85 of 86 checks passed
@J12934 J12934 moved this from Reviewer Approved to Done in secureCodeBox Jun 29, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Minio won't work on clusters with custom clusterDomain

3 participants