Skip to content

Add default RuntimeDefault SecComp Profile to Luker and change Capability to Uppercase to better match Security Policies #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
J12934 merged 4 commits into from
Jul 9, 2025
Merged

Add default RuntimeDefault SecComp Profile to Luker and change Capability to Uppercase to better match Security Policies #3116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e37e3b5
#2938 Change argument to uppercase for compatibility with other tools
Reet00 Jun 30, 2025
c948e15
#2939 Add configurable seccompProfile for lurker
Reet00 Jun 30, 2025
9f980c6
#2939 Change seccompProfile deauflt to RuntimeDefault
Reet00 Jul 8, 2025
063f11b
#2939 Update snapshot for helm unit test
Reet00 Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion operator/controllers/execution/scans/hook_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ func generateJobForHook(hookName string, hookSpec *executionv1.ScanCompletionHoo
ReadOnlyRootFilesystem: &truePointer,
Privileged: &falsePointer,
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"all"},
Drop: []corev1.Capability{"ALL"},
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion operator/controllers/execution/scans/parse_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ func (r *ScanReconciler) startParser(scan *executionv1.Scan) error {
ReadOnlyRootFilesystem: &truePointer,
Privileged: &falsePointer,
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"all"},
Drop: []corev1.Capability{"ALL"},
},
},
},
Expand Down
26 changes: 25 additions & 1 deletion operator/controllers/execution/scans/scan_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,27 @@ func (r *ScanReconciler) constructJobForScan(scan *executionv1.Scan, scanTypeSpe
return nil, fmt.Errorf("unknown imagePull Policy for lurker: %s", lurkerPullPolicyRaw)
}

seccompProfileRaw := os.Getenv("LURKER_SECCOMP_PROFILE")
var seccompProfile corev1.SeccompProfile
switch seccompProfileRaw {
case "Localhost":
seccompProfile = corev1.SeccompProfile{
Type: corev1.SeccompProfileTypeLocalhost,}
case "RuntimeDefault":
seccompProfile = corev1.SeccompProfile{
Type: corev1.SeccompProfileTypeRuntimeDefault,}
case "Unconfined":
seccompProfile = corev1.SeccompProfile{
Type: corev1.SeccompProfileTypeUnconfined,}
case "":
seccompProfile = corev1.SeccompProfile{
Type: corev1.SeccompProfileTypeRuntimeDefault,
}
default:
return nil, fmt.Errorf("unknown seccompProfile for lurker: %s", seccompProfileRaw)
}

r.Log.Info("Using Lurker Image", "seccompProfile", seccompProfileRaw)
falsePointer := false
truePointer := true

Expand Down Expand Up @@ -336,7 +357,10 @@ func (r *ScanReconciler) constructJobForScan(scan *executionv1.Scan, scanTypeSpe
ReadOnlyRootFilesystem: &truePointer,
Privileged: &falsePointer,
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"all"},
Drop: []corev1.Capability{"ALL"},
},
SeccompProfile: &corev1.SeccompProfile{
Type: seccompProfile.Type,
},
},
}
Expand Down
2 changes: 2 additions & 0 deletions operator/templates/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ spec:
value: "{{ .Values.lurker.image.repository }}:{{ .Values.lurker.image.tag | default .Chart.Version }}"
- name: LURKER_PULL_POLICY
value: {{ .Values.lurker.image.pullPolicy }}
- name: LURKER_SECCOMP_PROFILE
value: {{ .Values.securityContext.seccompProfile.type }}
{{- if .Values.customCACertificate.existingCertificate }}
- name: CUSTOM_CA_CERTIFICATE_EXISTING_CERTIFICATE
value: {{ .Values.customCACertificate.existingCertificate | quote }}
Expand Down
12 changes: 10 additions & 2 deletions operator/tests/__snapshot__/operator_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ matches the snapshot:
value: docker.io/securecodebox/lurker:0.0.0
- name: LURKER_PULL_POLICY
value: IfNotPresent
- name: LURKER_SECCOMP_PROFILE
value: RuntimeDefault
- name: CUSTOM_CA_CERTIFICATE_EXISTING_CERTIFICATE
value: foo
- name: CUSTOM_CA_CERTIFICATE_NAME
Expand Down Expand Up @@ -111,10 +113,12 @@ matches the snapshot:
allowPrivilegeEscalation: false
capabilities:
drop:
- all
- ALL
privileged: false
readOnlyRootFilesystem: true
runAsNonRoot: true
seccompProfile:
type: RuntimeDefault
volumeMounts:
- mountPath: /etc/ssl/certs/public.crt
name: ca-certificate
Expand Down Expand Up @@ -645,6 +649,8 @@ properly-renders-the-service-monitor-when-enabled:
value: docker.io/securecodebox/lurker:0.0.0
- name: LURKER_PULL_POLICY
value: IfNotPresent
- name: LURKER_SECCOMP_PROFILE
value: RuntimeDefault
- name: CUSTOM_CA_CERTIFICATE_EXISTING_CERTIFICATE
value: foo
- name: CUSTOM_CA_CERTIFICATE_NAME
Expand Down Expand Up @@ -688,10 +694,12 @@ properly-renders-the-service-monitor-when-enabled:
allowPrivilegeEscalation: false
capabilities:
drop:
- all
- ALL
privileged: false
readOnlyRootFilesystem: true
runAsNonRoot: true
seccompProfile:
type: RuntimeDefault
volumeMounts:
- mountPath: /etc/ssl/certs/public.crt
name: ca-certificate
Expand Down
6 changes: 5 additions & 1 deletion operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ securityContext:
capabilities:
drop:
# securityContext.capabilities.drop[0] -- This drops all linux privileges from the operator container. They are not required
- all
- ALL
seccompProfile:
# securityContext.seccompProfile.type -- one of RuntimeDefault, Unconfined, Localhost
# To disable seccompProfile, set to Unconfined. See: https://kubernetes.io/docs/tutorials/security/seccomp/
type: RuntimeDefault

# -- Sets the securityContext on the operators pod level. See: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-container
podSecurityContext: {}
Expand Down
Loading