Skip to content

Remove typo3scan Scanner - #3008

Merged
J12934 merged 4 commits into
secureCodeBox:mainfrom
J12934:feature/remove-typo3scan
May 7, 2025
Merged

J12934 merged 4 commits into
secureCodeBox:mainfrom
J12934:feature/remove-typo3scan

Conversation

@J12934

@J12934 J12934 commented Apr 29, 2025

Copy link
Copy Markdown
Member

Description

Removes typo3scan

I've left the old typo3 demo target in too for now.
Would like to discuss this on the next meeting, I'd be in favor of deleting it too.

Also changed generic tests which were using typo3scan to nmap (our most "stable" scan type)
Changed the ScheduledScan how-to to wpscan which seemed the most related & stable & relevant replacement

Closes #3007

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@J12934 J12934 added scanner Implement or update a security scanner breaking Changes requiring a major release labels Apr 29, 2025
@J12934 J12934 self-assigned this Apr 29, 2025
@secureCodeBoxBot

Copy link
Copy Markdown
Contributor

This pull request includes breaking changes. Please make sure that you included the breaking changes and the steps required to upgrade in Upgrading.
✨ Thank you for your contribution! ✨

@netlify

netlify Bot commented Apr 29, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 73dc59a
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/6819f548153c680008a02c8e

@J12934 J12934 moved this from Triage to To Review in secureCodeBox Apr 29, 2025
@Weltraumschaf
Weltraumschaf self-requested a review May 6, 2025 07:55

@Weltraumschaf Weltraumschaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some references:

documentation/docs/getting-started/upgrading.md
17:* `typo3scan` was removed as the scanner itself [isn't maintaned anymore](https://github.com/whoot/Typo3Scan?tab=readme-ov-file#unsupported). Most security aspects of typo3 are now hard to verify from the outside as it requires authentication (which is really good). Some typo3 security aspects (e.g. a incomplete installation) can be verified by [nuclei](https://www.securecodebox.io/docs/scanners/nuclei).

documentation/src/integrations.js
170:  "title": "Typo3Scan",
173:  "path": "docs/scanners/typo3scan",

operator/internal/telemetry/telemetry.go
48:	"typo3scan":                true, // deprecated. we'll keep it in this list to still recieve telemetry data from older versions

scanners/cmseek/scanner/Dockerfile
32:# Install Typo3Scan python requirements

@J12934

J12934 commented May 6, 2025

Copy link
Copy Markdown
Member Author

Found some references:

documentation/docs/getting-started/upgrading.md
17:* `typo3scan` was removed as the scanner itself [isn't maintaned anymore](https://github.com/whoot/Typo3Scan?tab=readme-ov-file#unsupported). Most security aspects of typo3 are now hard to verify from the outside as it requires authentication (which is really good). Some typo3 security aspects (e.g. a incomplete installation) can be verified by [nuclei](https://www.securecodebox.io/docs/scanners/nuclei).

documentation/src/integrations.js
170:  "title": "Typo3Scan",
173:  "path": "docs/scanners/typo3scan",

operator/internal/telemetry/telemetry.go
48:	"typo3scan":                true, // deprecated. we'll keep it in this list to still recieve telemetry data from older versions

scanners/cmseek/scanner/Dockerfile
32:# Install Typo3Scan python requirements

Fixed the Dockerfile and integrations.js one.
The other two need to remain there, (upgrading docs and the telemetry one has a comment explaining why it's there)

Will update the branch protection directly before merging.

@J12934
J12934 requested a review from Weltraumschaf May 6, 2025 10:01
@github-project-automation github-project-automation Bot moved this from To Review to Reviewer Approved in secureCodeBox May 6, 2025
J12934 and others added 4 commits May 6, 2025 13:40
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@Weltraumschaf
Weltraumschaf force-pushed the feature/remove-typo3scan branch from 4e149b3 to 73dc59a Compare May 6, 2025 11:40
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2025

Copy link
Copy Markdown

@J12934
J12934 merged commit 413a256 into secureCodeBox:main May 7, 2025
@github-project-automation github-project-automation Bot moved this from Reviewer Approved to Done in secureCodeBox May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Changes requiring a major release scanner Implement or update a security scanner

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove Typo3Scan

3 participants