Repository navigation
Update CI Workflow With New Build-Push-Action And more parallelization - #283
Merged
Merged
Conversation
I deleted everything in the CI to test a possible setup with the newer version of the build-push-action for docker images This Setup will build docker images with tags for: - current branch - current commit hash - custom tag `ci-local` - `lastest` tag (only if git tag is created) - semver tag: MAJOR.MINOR.PATCH Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com> Fix Docker Repo Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
To make working on forks more easy I introduced the github secret `DOCKER_NAMESPACE`. This secret contains the namespace in wich the docker images will be created. For example for the "golden" repository the namespace is currently `securecodebox` Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I introduced comments dividing the CI into multiple parts Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Notice that the lines actually executing the tests are commented out. This has to be done because my Fork does not have an id for code coverage The Job remains the same except for the name Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I added a local Registry to Cache the Docker Image Build from the nikto Repository To use the Image from the local registry I changed the Baseimage in the Dockerfile to localhost:5000/sullo/nikto Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
To add integration tests to the CI I had to specify the repository used for scanners as well as the parsers. This was necessary to ensure that the tests run on forks as well. Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I updated the contributing page because the CI should be fork friendly. I also added a Link to the Contributing Page in the README Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
J12934
reviewed
Jan 27, 2021
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight
marked this pull request as draft
January 28, 2021 09:10
nigthknight
force-pushed
the
update/ci
branch
3 times, most recently
from
January 28, 2021 09:46
18f3ab3 to
6533f38
Compare
The previous solution was prone to quotationmarks wrapping the version number. Using `yq` will resolve this Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight
force-pushed
the
update/ci
branch
from
January 28, 2021 10:33
6533f38 to
e13d10d
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
J12934
approved these changes
Feb 8, 2021
Member
|
After merge I've noticed two problems:
Both problems seem to come from the problem that their images and folder names are different. With the teams webhook I'm not so sure, should we rename the image to What do you think @fuhrmeistery @rseedorff ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will update the CI with a newer version of the docker-build-push-action.
To make this possible I had to introduce docker-meta-action to ensure all docker images are build with the tags needed.
Additional I changed the workflow to parallelize jobs where possible
I also extracted some variables:
I pinned the Scanner Versions using Dockerfile ARG
I read the Scanner Version from the corresponding Chart.yaml
I updated the Contributing Page for the new GH secrets
Before Merging:
closes #269