Add env for istio sidecar injection annotation closes #2652#2665
Merged
J12934 merged 5 commits intosecureCodeBox:mainfrom Sep 19, 2024
Merged
Add env for istio sidecar injection annotation closes #2652#2665J12934 merged 5 commits intosecureCodeBox:mainfrom
J12934 merged 5 commits intosecureCodeBox:mainfrom
Conversation
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com> Signed-off-by: Michael-Kruggel <michael.kruggel@defenseunicorns.com>
✅ Deploy Preview for docs-securecodebox canceled.
|
d21bde5 to
ce11b20
Compare
Signed-off-by: Michael-Kruggel <michael.kruggel@defenseunicorns.com>
Signed-off-by: Michael-Kruggel <michael.kruggel@defenseunicorns.com>
Contributor
Author
|
Not sure what happened with the fork and the extra commits, but if its a problem I can redo it. |
Contributor
Author
|
Also not sure whats going on with the Run sbctcl Tests. I ran it locally and it passed. |
Would potentially be confusing otherwise as the operator doesn't inject the istio sidecars, it's just allowing/preventing it. Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
|
Member
|
Awesome 🙌 (the scbctl test have started randomly failing in the pipeline since last week. very unlikely that this has to do anything with it.) |
J12934
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Signed-off-by: Jannik Hollenbach jannik.hollenbach@iteratec.com
Signed-off-by: Michael-Kruggel michael.kruggel@defenseunicorns.com<!--
Thank you for your contribution to our Project 🙌
Before submitting your Pull Request, please take the time to check the points below and provide some descriptive information.
For more information on content related and formal acceptance criteria for PRs, please have a look at our
docs.
-->
Description
Checklist