Skip to content

Add option to disable tls connection between the operator and the s3 endpoint #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
J12934 merged 3 commits into from
Sep 2, 2024
Merged

Add option to disable tls connection between the operator and the s3 endpoint #2637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f842aba
feat-add toggle for s3 tls
Michael-Kruggel Aug 27, 2024
7f16461
wip: add to contributors.md
Michael-Kruggel Aug 27, 2024
6089074
Merge branch 'main' into operator-s3-tls-toggle
Michael-Kruggel Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,4 @@ Committing with `git commit -s` will add the sign-off at the end of the commit m
- Kamiren Dawkins <kamiren@dawkins.dev>
- Tobias Stenby Brixen <kind.job1347@fastmail.com>
- Eline Henriksen <mains.moon.0x@icloud.com>
- Michael Kruggel <michael.kruggel@defenseunicorns.com>
2 changes: 1 addition & 1 deletion operator/templates/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:
{{- else }}
- name: S3_USE_SSL
# Always use tls when connecting to outside the cluster.
value: "true"
value: "{{ .Values.s3.tls.enabled }}"
- name: S3_ENDPOINT
value: {{ .Values.s3.endpoint | quote }}
- name: S3_BUCKET
Expand Down
2 changes: 2 additions & 0 deletions operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ minio:
s3:
# s3.enabled Enable this and disable minio if you want to directly connect against AWS S3, Google Cloud Storage, DigitalOcean Spaces etc.
enabled: false
tls:
enabled: true
endpoint: "fra1.digitaloceanspaces.com"
bucket: "my-bucket"
# Implicit 443. You probably only need to change this when the system uses a non default port
Expand Down