Support setting env variables for Scans generated by the Kubernetes AutoDiscovery#2628
Merged
J12934 merged 3 commits intosecureCodeBox:mainfrom Aug 27, 2024
Conversation
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
✅ Deploy Preview for docs-securecodebox canceled.
|
|
Reet00
approved these changes
Aug 27, 2024
Contributor
Reet00
left a comment
Reet00
left a comment
There was a problem hiding this comment.
Looks good. Test is also fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows to set the env vars on the Scan.
This can be helpful when you want to configure some part of the scan via the environment vars.
In particular I'd like to have this so that i can use the zap-automation-framework with a generic config and overwrite the target based on the service discovered by the auto-discovery.
Checklist