Add cascade CLI Command To Visualize Cascaded Scans Hierarchy#2608
Merged
J12934 merged 15 commits intosecureCodeBox:mainfrom Aug 18, 2024
Merged
Add cascade CLI Command To Visualize Cascaded Scans Hierarchy#2608J12934 merged 15 commits intosecureCodeBox:mainfrom
cascade CLI Command To Visualize Cascaded Scans Hierarchy#2608J12934 merged 15 commits intosecureCodeBox:mainfrom
Conversation
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
✅ Deploy Preview for docs-securecodebox canceled.
|
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
J12934
reviewed
Aug 16, 2024
Member
J12934
left a comment
J12934
left a comment
There was a problem hiding this comment.
Awesome, just tested this with a namespace with a couple of hundreds of scans and it works really well 🙌
Some smaller code style comments but other than that it should be good to go 🚀
scbctl/cmd/cascading_test.go
Outdated
| return m.Client, m.namespace, m.err | ||
| } | ||
|
|
||
| type testcases struct { |
Member
There was a problem hiding this comment.
Also seems unused, the tests seem to be using a inline type
Co-authored-by: Jannik Hollenbach <jannik@hollenbach.de> Signed-off-by: Freedisch <82499435+Freedisch@users.noreply.github.com>
Co-authored-by: Jannik Hollenbach <jannik@hollenbach.de> Signed-off-by: Freedisch <82499435+Freedisch@users.noreply.github.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
|
J12934
changed the title
cascade command for Cascading rulescascade CLI Command To Visualize Cascaded Scans Hierarchy
J12934
approved these changes
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
cascadecommand to display scans like a treestream issue #189
Checklist