Streamline CRD and RBAC Generation to avoid futher Issues#2348
Merged
J12934 merged 9 commits intosecureCodeBox:mainfrom Mar 12, 2024
Merged
Streamline CRD and RBAC Generation to avoid futher Issues#2348J12934 merged 9 commits intosecureCodeBox:mainfrom
J12934 merged 9 commits intosecureCodeBox:mainfrom
Conversation
… output them into the correct dirs Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
…icense headers Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
✅ Deploy Preview for docs-securecodebox canceled.
|
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
|
Member
|
Nice that we finally resolve this ^_^ |
Member
Author
Not sure if it was forgotten or later overwritten by something else. But it definitely should have been there 😅 |
Ilyesbdlala
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the controller-manager config to directly generate the CRDs and RBAC rules in the dirs used by the helm chart rather than the (mostly) unused config folders. These were autogenerated by kubebuilder but we stopped using these quite a while back. So I completly removed them to remove some hassle.
Checklist